Thanks for this brilliant idea about wifichanviz HOT 2 OPEN

Hello @tobozo,

could it mean the whole channels list is off by one?

That's precisely the case!
No wonder you had problems with your ConBee. 😄

your changes seem to dramatically improve the frame rate 👍

La chose la plus difficile c'est d'avoir l'idée la plus simple.

Thanks for your tip about significant luminance values depending on the screen brightness. I'm keeping this in mind, even though no one uses the ESPboy's screen backlight LED. I think I'm the only one who does, but only in specific cases: to simulate fades between splash screens.

Thanks again for your constructive feedback.

Steph

from wifichanviz.

Salutations @m1cr0lab

thanks for your feedback, I'm happy my work inspired you :-)

dpc[channel - 1]++;

could it mean the whole channels list is off by one?

this app was supposed to help me pick an idle wifi channel to have my ConBee dongle collect data from my Linky ... and I've been wondering why my zigbee network had such a big packet loss ratio 🤦

thanks for spotting that!

calculating the luminance for the historical perspective fade:

your changes seem to dramatically improve the frame rate 👍

pour ma défense I initially wanted to have the luminance vary depending on the display brightness but the min-max values weren't consistent across M5 devices and the code block to handle that was removed.

however before removing this feature I found out there are 4 significant luminance levels (e.g. 1, 2, 4, 8) to map between max and min brightness in order to keep the graph horizon visible.

I believe the ESPBoy could benefit from that tweak, all you need is to set those 1/2/1 values as variables too:

  static uint8_t rl, gl, bl; // don't forget to init in setup()!

  void onBrightnessChanged( uint8_t brightness,  uint8_t min_brightness=0x00, uint8_t max_brightness=0xff )
  {
    // on brightness change
    uint8_t luminance = map( brightness, max_brightness, min_brightness, 1, 4 );
    rl = luminance;
    gl = luminance*2;
    bl = luminance;
  }

  // (...)

  for (uint16_t i = 0; i < len; ++i) {
    if (fb[i]) {
      // (... )    
      r = r > rl ? r - rl : 0;
      g = g > gl ? g - gl : 0;
      b = b > bl ? b - bl : 0;
     // (...)
    }
  }

be well

from wifichanviz.