Giter Club home page Giter Club logo

Comments (9)

sebastic avatar sebastic commented on July 24, 2024 1

The package builds on the Debian infrastructure haven't started yet at time of writing, this is my local build log:

spatialindex.log

Note the use of -DCMAKE_BUILD_TYPE=None which allows the use of the buildflags set in the environment by dpkg-buildflags.

from rtree.

hobu avatar hobu commented on July 24, 2024

Thanks for the patch!

I suppose we should just relax the version test or remote it entirely. It doesn't add too much at this point

Lost pointers: 0

Are you purposely building in Debug mode or is it accidentally being enabled?

from rtree.

hobu avatar hobu commented on July 24, 2024

Answering my own question, NDEBUG is being set by CMake regardless of build type. I will fix with a new beta of libspatialindex.

from rtree.

hobu avatar hobu commented on July 24, 2024

libspatialindex/libspatialindex#246 addressed the extra debug noise here

from rtree.

adamjstewart avatar adamjstewart commented on July 24, 2024

This patch may suffice:

FWIW, it would be easier to write this as:

self.assertTrue((index.major_version, index.minor_version) >= (1, 7))

and it would work for version 3 too. But removing the test makes more sense in this case.

from rtree.

hobu avatar hobu commented on July 24, 2024

New libspatialindex beta available related to this https://github.com/libspatialindex/libspatialindex/releases/tag/2.0.0b2

from rtree.

sebastic avatar sebastic commented on July 24, 2024

No change with respect to the "Lost pointers" output with b2:

I: pybuild base:311: cd /build/python-rtree-1.2.0/.pybuild/cpython3_3.12_rtree/build; python3.12 -m pytest tests
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-8.2.1, pluggy-1.5.0
rootdir: /build/python-rtree-1.2.0/.pybuild/cpython3_3.12_rtree/build
configfile: pyproject.toml
collected 39 items

tests/test_finder.py ..                                                  [  5%]
tests/test_index.py .......x...........Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
.................                 [ 97%]
tests/test_tpr.py .                                                      [100%]

======================== 38 passed, 1 xfailed in 0.28s =========================
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
I: pybuild base:311: cd /build/python-rtree-1.2.0/.pybuild/cpython3_3.11_rtree/build; python3.11 -m pytest tests
============================= test session starts ==============================
platform linux -- Python 3.11.9, pytest-8.2.1, pluggy-1.5.0
rootdir: /build/python-rtree-1.2.0/.pybuild/cpython3_3.11_rtree/build
configfile: pyproject.toml
collected 39 items

tests/test_finder.py ..                                                  [  5%]
tests/test_index.py .......x...........Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
.................                 [ 97%]
tests/test_tpr.py .                                                      [100%]

======================== 38 passed, 1 xfailed in 0.30s =========================
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0
Lost pointers: 0

from rtree.

hobu avatar hobu commented on July 24, 2024

No change with respect to the "Lost pointers" output with b2:

Hmph. Can you point me to where libspatialindex is being configured? I believe I had b2 set up so that if any Debug (RelWithDebInfo/Debug) is set as the CMAKE_BUILD_TYPE, it will output that stuff.

Maybe it isn't worth the trouble at all I we should just drop it. Modern analysis tools can tell you all that stuff easily...

from rtree.

hobu avatar hobu commented on July 24, 2024

New release should take care of this https://github.com/libspatialindex/libspatialindex/releases/tag/2.0.0b3

from rtree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.