Giter Club home page Giter Club logo

Comments (9)

tobimori avatar tobimori commented on May 31, 2024 2

I guess most websites don't use it. There are things where it make sense so having it as a different plugin is totally valid.

from kirby-seo.

tobimori avatar tobimori commented on May 31, 2024 1

Unfortunately it's not really possible to keep only a part of the schema classes since they're automatically generated. I'd have to maintain a separate version, which would be a lot of work that's not worth it for me. Code size is a veryyy minimal benefit.

A panel UI is not included since IMO it's too complicated to make it feature-complete and/or accessible to editors as well.

from kirby-seo.

tobimori avatar tobimori commented on May 31, 2024

Too much effort to maintain two separate versions of this plugin

from kirby-seo.

afbora avatar afbora commented on May 31, 2024

Thanks. Can I create/fork lite version of your plugin?

from kirby-seo.

tobimori avatar tobimori commented on May 31, 2024

Sure

from kirby-seo.

tobimori avatar tobimori commented on May 31, 2024

Is there a thing such as peer dependencies in PHP? Could we eventually realize this by omitting the dependency from the plugin, and only having the feature availalbe if the user has installed the package themselves?

from kirby-seo.

afbora avatar afbora commented on May 31, 2024

Make sense. I think it can be enabled by making a secondary plugin and checking option (tobimori.seo.schema => true) or existing class.

from kirby-seo.

afbora avatar afbora commented on May 31, 2024

I ask because I don't know very well: Is schema a very used feature in terms of SEO? If so, it doesn't make sense to separate it? If it is a little or rarely used feature, separating it may be more beneficial in terms of performance.

from kirby-seo.

andreasba avatar andreasba commented on May 31, 2024

I second this - especially if there is no GUI/snippet for a panel to set the specific schema for each site manually, I think in 99.999% of the cases the default will apply.

IHMO it makes sense to keep the top 10-15 schema classes in the package and outsource the rest to a different plugin, if needed.

from kirby-seo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.