I'm trying to expand the capture_pane functionality.<

I took a run at it with the debugger and it seems to hang in <div class="Box Box--

Is this possibly the problem? <a href="https://stackoverflow.com/questions/1445627/how

The following patch appears to work <div class="highlight highlight-source-diff no

Merged <a class="issue-link js-issue-link" data-error-text="Failed to load title" data

Many thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hoverc

capture_pane hangs with `-S-` about libtmux HOT 6 OPEN

tmux-python commented on May 25, 2024

capture_pane hangs with `-S-`

from libtmux.

Comments (6)

deliciouslytyped commented on May 25, 2024

I took a run at it with the debugger and it seems to hang in

libtmux/libtmux/common.py

Line 208 in 1331743

self.process.wait()

from libtmux.

deliciouslytyped commented on May 25, 2024

Is this possibly the problem? https://stackoverflow.com/questions/1445627/how-can-i-find-out-why-subprocess-popen-wait-waits-forever-if-stdout-pipe

Some more stuff https://stackoverflow.com/questions/30982217/python-popen-wait-vs-communicate-vs-calledprocesserror

from libtmux.

deliciouslytyped commented on May 25, 2024

The following patch appears to work

diff --git a/libtmux/common.py b/libtmux/common.py
index 9681d3e..64f4313 100644
--- a/libtmux/common.py
+++ b/libtmux/common.py
@@ -205,11 +205,7 @@ class tmux_cmd(object):
             self.process = subprocess.Popen(
                 cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE
             )
-            self.process.wait()
-            stdout = self.process.stdout.read()
-            self.process.stdout.close()
-            stderr = self.process.stderr.read()
-            self.process.stderr.close()
+            stdout, stderr = self.process.communicate()
             returncode = self.process.returncode
         except Exception as e:
             logger.error('Exception for %s: \n%s' % (subprocess.list2cmdline(cmd), e))