clean_plugins cleared out home directory with missing TMUX_PLUGIN_MANAGER_PATH about tpm HOT 11 CLOSED

I'd be happy to help out.

from tpm.

Hi, I have also run into this bug and it's seriously pretty bad. Any updates on this?

from tpm.

Guys, I'm so shamed this one is open for so long.
I obviously need help maintaining this project. Who do you think would be a good fit? @Graham42 can you help?

from tpm.

This is pretty bad. I'll look into this asap.

from tpm.

I can confirm this bug.

As it is rather serious and still not fixed after two months, maybe add a temporary safety?
It would be sufficient to exit the script if $(tpm_path) returns an empty string. (It's even best to add that check permanently)

For me, the problem arose when i used an automated script that didn't check the tmux version and called the install and clean scripts directly. Because of this the tpm script didn't load the vars (tmux version to low) and the install and cleanup scripts don't have there own checks and tried to do their thing without the correct vars being set.

from tpm.

As this project seems to be dead, I just wrote my own plugin manager as an extension for ellipsis.

Both Ellipsis and Ellipsis-TPM could still use a lot of work, butt it's stable and functional. Feel free to join the Ellipsis community!

Although I have my own manager now, I do hope this project get's a new maintainer. (Or Bruno finds the time again)

from tpm.

+1. It destroyed my home directory too 😣

from tpm.

Happend to me too. I think the root of the problem is not related to the environment variable (ultimately it is), or if you call clean_plugins outside of a tmux session (which is claimed to be supported). Calling the clean_plugins command without tmux being installed will remove $HOME, because the check_tmux_version.sh file (and no other code, I think) is checking if tmux is actually installed. Setting the environment variable is however done using a call to the tmux program, which obviously fails if it's not installed. I think this can be fixed by either:

• Requiring tmux to be installed before cleaning anything
• Don't only set the environment variable using tmux, but actually export it so it's set even if tmux is not installed

Maybe it might be worth considering to switch the project lead to another person (or to add maintainers to it) so that the project can actively be maintained. Bugs as this one are rather serious and should be fixed as soon as possible.

Thanks!

from tpm.

A temporary workaround is to add export TMUX_PLUGIN_MANAGER_PATH="$HOME/.tmux/plugins"
in .zshrc profile.

from tpm.

If anyone wants a fork of tpm that fixes this issue, check out mine: https://github.com/Graham42/tpm
see below

from tpm.

Hi @bruno- , we didn't see you here for a long time, it's a pity that you don't have a time for your projects, I really like work, it helps me a lot
Hope you are doing well 😇

from tpm.