Giter Club home page Giter Club logo

Comments (6)

YorikSar avatar YorikSar commented on August 18, 2024

YorikSar@3587afe

The first approach uses nothing special, only vspec. It looks like this will become huge and ugly if we have to write each test like this.

from simpylfold.

YorikSar avatar YorikSar commented on August 18, 2024

YorikSar@6fb9f29

This adds some more preprocessing to vspec and allows to embed chunks of Python code to verify folding in testcases. It looks better, but introduces another script for preprocessing.

I'm thinking about pushing it forward and writing preprocessor that would work with *.py files and spit out vspec scripts.

from simpylfold.

tmhedberg avatar tmhedberg commented on August 18, 2024

I like the cleaner test syntax of the second example, but I worry that the complexity of the preprocessing code required to implement it runs counter to the "keep it simple" theme of this plugin. I don't ever expect this project to grow a lot of additional features beyond what it already has, so it may end up being worth keeping the test support code simple even if that makes the syntax of the test cases themselves uglier, since we won't need that many tests to cover everything this plugin can do. But I'll reserve final judgment until you've had a chance to hack on this a little more.

In any case, I really appreciate what you're doing!

from simpylfold.

iago-lito avatar iago-lito commented on August 18, 2024

Still working on #67, I need to perform kind of a substantial refactoring. Maybe YorikStar's project is not finished yet, but.. do you have any official test files I could use in order to ensure that I am not breaking anything? I wouldn't like to offer a pull request with only half of the feature surviving the experience :P

from simpylfold.

tmhedberg avatar tmhedberg commented on August 18, 2024

I'm afraid not. It would be a useful addition to the project, but no one has put anything together so far.

I appreciate your desire to refactor responsibly, though. :) If you create even a simple test file for your own purposes, I'd be happy to include it here. Even if it doesn't cover all possible scenarios, it's better than having nothing at all.

from simpylfold.

iago-lito avatar iago-lito commented on August 18, 2024

Okay, let's do this then. I'll write test files myself and consider the refactoring non-regressive if it works for them. When this happens (`can't tell when) , feel free to warn we if I've missed anything :)

from simpylfold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.