Comments (6)
The first approach uses nothing special, only vspec. It looks like this will become huge and ugly if we have to write each test like this.
from simpylfold.
This adds some more preprocessing to vspec and allows to embed chunks of Python code to verify folding in testcases. It looks better, but introduces another script for preprocessing.
I'm thinking about pushing it forward and writing preprocessor that would work with *.py files and spit out vspec scripts.
from simpylfold.
I like the cleaner test syntax of the second example, but I worry that the complexity of the preprocessing code required to implement it runs counter to the "keep it simple" theme of this plugin. I don't ever expect this project to grow a lot of additional features beyond what it already has, so it may end up being worth keeping the test support code simple even if that makes the syntax of the test cases themselves uglier, since we won't need that many tests to cover everything this plugin can do. But I'll reserve final judgment until you've had a chance to hack on this a little more.
In any case, I really appreciate what you're doing!
from simpylfold.
Still working on #67, I need to perform kind of a substantial refactoring. Maybe YorikStar's project is not finished yet, but.. do you have any official test files I could use in order to ensure that I am not breaking anything? I wouldn't like to offer a pull request with only half of the feature surviving the experience :P
from simpylfold.
I'm afraid not. It would be a useful addition to the project, but no one has put anything together so far.
I appreciate your desire to refactor responsibly, though. :) If you create even a simple test file for your own purposes, I'd be happy to include it here. Even if it doesn't cover all possible scenarios, it's better than having nothing at all.
from simpylfold.
Okay, let's do this then. I'll write test files myself and consider the refactoring non-regressive if it works for them. When this happens (`can't tell when) , feel free to warn we if I've missed anything :)
from simpylfold.
Related Issues (20)
- Folds are invalid after running formatter with ale HOT 3
- Releases Support HOT 1
- More configuration HOT 2
- SimpylFold with large modules makes basic operations slow HOT 3
- Auto close fold include current line after delete line HOT 5
- Comment BLOCKS (in file licenses)
- Plugin ceases to work if a module is named after its parent directory HOT 1
- docstring folding not working with empty line HOT 2
- Support folding long block of code by indentation? HOT 4
- Plugin is not working on Ubuntu Vi IMproved 8.0 HOT 3
- Folds only exist after using zx (E490: No fold found) when using "telescope" fzf plugin HOT 6
- Support for other languages? HOT 1
- is it possible to have only 1 line separating folds ? HOT 2
- the function/class names should have an higher contrast than the lines numbers HOT 3
- Possibility of defining custom folds? HOT 1
- Repository not found HOT 1
- Folding Code in Child Classes HOT 2
- SimpylFold won't indent top level functions HOT 4
- Can't turn off docstring folding HOT 5
- SimpylFold not working (E490: no fold found) on macOS Sonoma with Vundle HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simpylfold.