nextStep can return -1 in Monster.c:2020 about broguece HOT 8 CLOSED

Amazing work guys!

from broguece.

Thanks for the report. On what turn do you get these errors? And do they cause an out-of-sync error? I get an out-of-sync error on turn 686, does that seem right?

from broguece.

Yeah, the errors happen at turn 686, however I do not get an out-of-sync error.

from broguece.

I also have a out-of-sync at turn 686 when view your recording. You press "j" to go in water. Can we find seed in the recording file ? Or have you the seed ?

from broguece.

The seed is 232800572

from broguece.

Ok! Looks like this is an out-of-sync bug. Good find, now we need to work out the cause.

from broguece.

I found another recording with this issue at turn 790, if that helps.

from broguece.

I've found the cause of this issue.

If you go to turn 686 on your first recording, there are two small pools, each containing an eel. By some strange dungeon generation (bug?), those two eels are actually part of the same horde: one is a follower of the other. So the follower, being more than 2 cells away from its leader (condition in monstersTurn at Monsters.c:3350), tries to path towards the other eel with pathTowardCreature. However, there is no traversable path to follow - so nextStep returns -1, which isn't checked, and hence invalid access occurs.

This is a really good find, thanks for the report!

from broguece.