Giter Club home page Giter Club logo

Comments (7)

zlatanvasovic avatar zlatanvasovic commented on June 11, 2024 1

You can click it, but only on 10px of its right side. After that, you can't.

I'll send a fix soon. 😄

It turns out the needed fix was just to set one dimension to a concrete value (based on Bootstrap docs). max-height and height are identical in this case anyway (the logo will be 25px).

from pkgpage.jl.

Roger-luo avatar Roger-luo commented on June 11, 2024 1

Thanks for the quick fix!

from pkgpage.jl.

Roger-luo avatar Roger-luo commented on June 11, 2024

It seems can be fixed if I disable the logo. The LOGO span somehow is too large and it covers the package name and the Docs

from pkgpage.jl.

tlienart avatar tlienart commented on June 11, 2024

Thanks for the report! so can I summarise the issue as follows?:

  • if there's a top-nav logo + docs button; the docs button is not clickable
  • the likely culprit is that the navbar-brand span for the top-nav logo is too wide

@zdroid would you mind having a look at this one? thanks!!

from pkgpage.jl.

zlatanvasovic avatar zlatanvasovic commented on June 11, 2024

This is also an issue with PkgPage.jl's page, since "PkgPage.jl" can't be clicked.

The problem is that we were using navbar-brand incorrectly: https://getbootstrap.com/docs/4.5/components/navbar/#supported-content. It is not supposed to be used with 2 links, but just with one. I suggest we move Docs out of navbar-brand and put it maybe on the right side?

from pkgpage.jl.

tlienart avatar tlienart commented on June 11, 2024

since "PkgPage.jl" can't be clicked.

is this a browser issue? I have no problem clicking it.

I suggest we move Docs out of navbar-brand and put it maybe on the right side?

sounds good, would you mind opening a PR with this? thanks! 🙏

from pkgpage.jl.

tlienart avatar tlienart commented on June 11, 2024

@Roger-luo this should be fixed & released (thanks Zlatan!) let us know if you still have an issue

from pkgpage.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.