Comments (13)
No, we didn't take care of this yet. Here's more info. It will just stay there until you manually delete it. But it has nothing to do with this issue.
from tldr-c-client.
from tldr-c-client.
Update: I figured out the issue. In Linux (and probably macOS too) /tmp
has it's own filesystem called tmpfs
. We now try to rename the tldr directory in /tmp/tldrXXXX/tldr-main
to ~/.tldrc/tldr
, which doesn't work, because the rename()
command doesn't support that. It set's the errno code 18 - Invalid cross-device link
. This issue even existed in the code more than 5 years ago. Honestly, I'm wondering how this worked at all...
I'm currently making a PR to replace the rename()
function to a copy()
and delete()
.
from tldr-c-client.
I started by checking I was still seeing the issue:
Geoffs-MacBook-Pro:~ $ tldr -u
Error: Could Not Rename: /tmp/tldrYmdBuU/tldr to /Users/xxxxx/.tldrc/tldr/
Geoffs-MacBook-Pro:~ $ brew install tldr --HEAD
Updating Homebrew...
==> Auto-updated Homebrew!Updated 3 taps (homebrew/cask-versions, homebrew/core and homebrew/cask).
Error: tldr 1.4.0 is already installed
To install HEAD, first run:
brew unlink tldr
Geoffs-MacBook-Pro:~ $ brew unlink tldr
Unlinking /usr/local/Cellar/tldr/1.4.0... 5 symlinks removed.
Geoffs-MacBook-Pro:~ $ brew install tldr --HEAD
==> Cloning https://github.com/tldr-pages/tldr-c-client.git
Cloning into '/Users/xxxxx/Library/Caches/Homebrew/tldr--git'...
==> Checking out branch master
Already on 'master'
Your branch is up to date with 'origin/master'.
==> make PREFIX=/usr/local/Cellar/tldr/HEAD-2faf09e install
==> Caveats
Bash completion has been installed to:
/usr/local/etc/bash_completion.d
==> Summary
🍺 /usr/local/Cellar/tldr/HEAD-2faf09e: 10 files, 82.1KB, built in 11 seconds
Removing: /Users/xxxxx/Library/Caches/Homebrew/tldr--1.4.0... (14.7KB)
Geoffs-MacBook-Pro:~ $ tldr -u
Successfully updated local database
Geoffs-MacBook-Pro:~ $
I needed to unlink, but after that it worked, which is great! Thank you very much.
Not critical but tldr -v
returns tldr v1.3.0 (v1.4.0-2-g2faf09e)
. Oh and I checked in the .tldrc
directory and found both tldr-main
and tldr-master
which I believe is as expected.
If that was not what you wanted, or I did something wrong, please just ask.
from tldr-c-client.
Thanks, that was exactly what I wanted to know. We will create a new release with the fix soon, so you can get the new version without the --HEAD
flag.
from tldr-c-client.
I just released the fix. Thanks for your help @glawrence
from tldr-c-client.
This is almost definitely #59
Did the fix work from #21
from tldr-c-client.
I tried the fix at #21 (comment) which did not work for me. However I note that, as above tldr -v -u
shows main.zip and the instructions on #21 I just linked to refer to master.zip
from tldr-c-client.
This is really strange, because I made #59 to fix exactly this issue and it worked for me. Now, I'm getting the same error.
from tldr-c-client.
Argh, how annoying @marchersimon ! I guess on the plus side, from our point of view, it is useful you can reproduce the issue.... Happy to try and help by testing stuff on macOS
from tldr-c-client.
The main reason this is failing is, because the archive we download is called main.zip
, because it's coming from the main
branch. The archive contains the directory tldr-main/
, so when we extract main.zip
, we get tldr-main
, which the program doesn't expect. I'll keep you up to date.
from tldr-c-client.
Will it remove ~/.tldrc/tldr-master
as part of the process? I am guessing that's not needed, although removing it might stop tldr from working, I guess
from tldr-c-client.
@glawrence the fix for macOS is merged now. Could you please verify that it's working by updating your client using the --HEAD
opption?
from tldr-c-client.
Related Issues (20)
- `-l` option for `tldr` command is ambiguous, inconsistent with help message HOT 3
- tldr autocomplete call the alias version of find
- Error: Downloading file: https://github.com/tldr-pages/tldr/archive/main.zip HOT 1
- Use Docker container to help tldr-c-client development
- Update changelog
- This version is slower than the Python one HOT 2
- 'tldr --list' segfaults on macOS HOT 3
- Segmentation fault HOT 1
- it didn't works on my Mac HOT 1
- New completion for fish HOT 1
- Make fails to find libzip and curl when using /opt/homebrew
- Feature request: auto-update tldr pages HOT 2
- Error on Mac 11.6 with brew install tldr HOT 3
- Colours are very difficult to read
- [Bug] Autocompletion for fish shell breaks with an error
- Can't `tldr --update` when installed from Brew on Linux
- Autocomplete in zsh throws error: parse error near `\n' HOT 2
- Slow tldr -u (tldr --update) HOT 20
- Error: Could Not Rename: ... to ... HOT 6
- Search other platform folders for command if not found under current platform or common HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tldr-c-client.