Adding gnu/posix style command line options to ZigBeeConsoleJavaSE about zigbee4java HOT 2 OPEN

For me, this all looks good. I just wonder if it is best to use a builder notation, or a config dictionary.

from zigbee4java.

I'm wondering the same thing. I've started with the builder but I don't like it. The above options and possibly more need to be passed from the outermost class to the innermost one. Some options are consumed by classes in between. With Builder we need to create a parallel hierarchy of builders one for every class so that adding a new option might require to change every builder in the hierarchy. A dictionary might be simpler especially if the above configuration is read from a file. However, simply passing the dictionary to every constructor in the hierarchy is not that safe. You don't know who is using what configuration.

I've spent more time on this... Why don't we move the instantiation of the ZigBeeApi outside of ZigBeeConsole and pass it a reference to the instance?

Pros

• we remove one layer to the hierarchy (less parameters to pass through)
• given that the ZigBeeApi instance is not owned by the ZigBeeConsole, we can enhance the application adding logic that otherwise would require modifying the ZigBeeConsole class. The ZigBeeConsole class is just a useful and pluggable "View" on the ZigBee network.

Cons

• The ZigBeeApi instantiation code must be duplicated in the javase and android console. However this code is just twenty lines or so.

Ciao,
Cristiano

from zigbee4java.