More modular design about keypather HOT 5 CLOSED

Quick thoughts: I like this idea a lot (splitting each operation into it's own module/file)

from keypather.

👍

I think #10 could be solved with this one too.

from keypather.

Hey @tjmehta ... In trying to decompose the index.js and it's methods, I've made the code a little uglier I feel. (I'll reference my branch when I load it... )

Let me explain where I'm at: I love seeing solid use of prototype like this, however I'm currently breaking it up into more basic utility-function design ( sub-classes and prototype might be overkill for this. Ultimately I think a skinny+modular design will come from using a direct require('./lib/xyz') design - accessing state-less/instance-less feature methods). So index.js would look like a little like this: exports.get = require('./lib/get') this would make it 'instance-free' and each call's lifetime is clearly scoped: run's in it's own closure, allowing better garbage collection

Current progress/thoughts

1. I've been re-factoring the getValue fn and it's dependent method chain,
   1. Moved fns: handleKey, handleFunction, handleBrackets under getValue
2. Can in() and has() be updated to use get() directly?

from keypather.

Other thoughts

In order to design (what I think is) an ideal plugin model, I usually assume an infinite possible # of plugins... While this is probably not a likely requirement for a module with most functionality included - hopefully this will just make code more tightly scoped)
I typically design a plugin interface with members like: run(obj), int priority (maybe a hasRun(obj) et al.)
For keypather, I think a plugin interface method like canRun(keyPath) or isNeeded(keyPath) would cleanly separate the main class out, so it's just a coordinator/controller simply running 'steps'

This should also allow for more isomorphic usage patterns - perhaps like this:

var basicGet = Keypather.run.bind([require('./plugins/dottedPaths'), require('./plugins/expandPath')])
var getArray = Keypather.run.bind([require('./plugins/dottedPaths'), require('./plugins/arrayPaths'), require('./plugins/expandPath')])

from keypather.

published [email protected] !

from keypather.