Why not just use [].slice? about node-thunkify HOT 3 CLOSED

#12

发件人: Deng Ruoqimailto:[email protected]
发送时间: ‎2014/‎6/‎11 22:15
收件人: visionmedia/node-thunkifymailto:[email protected]
主题: [node-thunkify] Why not just use [].slice? (#13)

@visionmedia there is a code snippet in thunk module:

return function(){
    var args = new Array(arguments.length);
    var ctx = this;

    for(var i = 0; i < args.length; ++i) {
      args[i] = arguments[i];
    }
    ...
}

I'm just curious about why not just use the code below which is simpler?Is there some problem with it?

var args = [].slice.call(arguments);

Reply to this email directly or view it on GitHub:
#13

from node-thunkify.

doesn't matter much either way, even the optimization we made is a micro one, it's still millions of ops/s, so I guess the answer would be that [].slice() would be just fine as well

from node-thunkify.

@coderhaoxin , aha, that's awsome! Thanks!

from node-thunkify.