[BUG] any_modified/any_changed outputs are false for Pull Requests if no filters are set about changed-files HOT 5 CLOSED

Given the unique use case I’ve added support for setting the outputs to true but noting that it would only be false if a pattern is specified.

from changed-files.

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

from changed-files.

Hi @AndreyNautilus, to clarify the any_{changed, modified} outputs. As highlighted in the documentation, requires at least one file pattern.

If you intend to have an empty file passed to the files_ignore_from_source_file input in such a scenario both outputs would remain false.

The any in the context of the output specifically means "any of the files I want to filter" which doesn't apply to cases when no filters are specified.

I hope that clears things up.

from changed-files.

@jackton1 thanks for the explanation.
Then the documentation is a bit confusing. As you pointed out the description for the output says:

Returns true when any of the filenames provided using the files or files_ignore inputs have changed

while the description for files input says:

File and directory patterns used to detect changes (Defaults to the entire repo if unset).

Which makes an impression that if files input is omitted, it defaults to something like **, and that should make any_changed/any_modified outputs true.

I agree with "not a bug" resolution, but it seems the documentation should be a bit more accurate.

from changed-files.

Thank you for the fix!

from changed-files.