Issue with similar function for arrays about odiff HOT 3 CLOSED

Hi Paddy, thanks for pointing that out. I think you're correc that this is a logical error. It shouldn't result in any invalid results, but will change how it optimizes structuring the results. Would you be willing to write up a small PR to fix this (with a unit test that would fail on the current incorrect code)?

from odiff.

Hi @fresheneesz, I'm sorry I don't currently have the time to go through fixing this, testing it properly, and double-checking the results. Fortunately, as you point out, it doesn't affect the correctness of the results. After all, odiff has been in use for many years without this being noticed. However, I thought it'd be good to highlight it in case anyone has the time to fix it in the future. I'll keep this in mind to come back to when I have more time.

All the best,
~ Paddy L.

from odiff.

Ok I created a fix. Thanks again for reporting!

from odiff.