Giter Club home page Giter Club logo

Comments (7)

chachra avatar chachra commented on July 30, 2024 1

@akhayyat - acknowledged and we'll work on a fix asap.

from django-cron.

maxim-kht avatar maxim-kht commented on July 30, 2024 1

The fix is deployed https://pypi.python.org/pypi/django-cron/

from django-cron.

akhayyat avatar akhayyat commented on July 30, 2024 1

Works perfectly! Thank you very much for the prompt resolution.

from django-cron.

prokaktus avatar prokaktus commented on July 30, 2024

Doesn't it break backward-compatibility? Looks like it did. Because add_arguments was added in Django 1.8.

@bctiemann do you know recommended way to check Django version and depending on it define or not define attributes and functions?

from django-cron.

bctiemann avatar bctiemann commented on July 30, 2024

I'm not sure if there's a canonical way, but what if you check whether the add_arguments method is defined in the BaseCommand superclass?

from django-cron.

prokaktus avatar prokaktus commented on July 30, 2024

@bctiemann thanks for your suggestion!

from django-cron.

akhayyat avatar akhayyat commented on July 30, 2024

Django 1.10 has now been released, and this issue no longer is a deprecation warning; it breaks django-cron on Django 1.10. Upon running the manage.py runcrons, I get:

AttributeError: type object 'BaseCommand' has no attribute 'option_list'

Could a fixed release be made available? That would be greatly appreciated!

BTW, it seems to be common to check Django's version using django.get_version() (string) or django.VERSION (tuple) to support multiple versions and avoid breaking backward compatibility, e.g.:

if django.get_version().split('.') < ['1', '10']:
    # old version friendly code
else:
    # new version friendly code

from django-cron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.