Giter Club home page Giter Club logo

Comments (4)

tisoap avatar tisoap commented on May 18, 2024

Hey @lichenglu thanks for pointing it out! When I choose pathfinding as a dependency I didn't care that it wasn't being maintained anymore, since "path finding" is a solved problem, but turns out there's still bugs in it.

I don't feel confident in forking/maintaining it, which leaves the option to find another up to date dependency

from react-flow-smart-edge.

lichenglu avatar lichenglu commented on May 18, 2024

Hey @lichenglu thanks for pointing it out! When I choose pathfinding as a dependency I didn't care that it wasn't being maintained anymore, since "path finding" is a solved problem, but turns out there's still bugs in it.
I don't feel confident in forking/maintaining it, which leaves the option to find another up to date dependency

That makes sense as I would expect it to be a mature enough problem with robust solutions. Do you have an alternative in mind? I have briefly looked around and it seems https://github.com/prettymuchbryce/easystarjs can be used to easily replace pathfinding. However, easystarjs seems only support the A* algorithm and I noticed in other issues that JumpPointFinder might be needed in the future.

P.S. I would love to help revamp the use of path finding if you don't mind determining an alternative package

from react-flow-smart-edge.

tisoap avatar tisoap commented on May 18, 2024

Thinking on how to circumvent this without putting the burden on me to update/change the path finding dependency, I'm planning to create a factory function. Developers can "build" their own versions of a smart edge passing down configurations to this factory function, and I'll expose the option to change the default path finding function.

from react-flow-smart-edge.

tisoap avatar tisoap commented on May 18, 2024

Hey @lichenglu ! I've released a beta version that makes it possible to configure the path finding function using a smartEdgeFactory, could you test if it can be used to solve your use case?

Available to test using the beta tag:

npm install @tisoap/react-flow-smart-edge@beta

New documentation can be found here

EDIT: Version 1.0 released with this feature

from react-flow-smart-edge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.