DRIP's DisseminationEngineImplP does not check busy flag when receiving old version neighbor about tinyos-main HOT 3 CLOSED

From [email protected] on January 13, 2011 17:08:39
I see line 224 as

event message_t* ProbeReceive.receive( message_t* msg,
void* payload,
uint8_t len) {

dissemination_probe_message_t* dpMsg = 

224-> (dissemination_probe_message_t*) payload;

if ( !m_running ) { return msg; }

if ( call DisseminationCache.requestSeqno[ dpMsg->key ]() != 
 DISSEMINATION_SEQNO_UNKNOWN ) {    
  sendObject( dpMsg->key );
}

return msg;

}

Which version of the file are you looking at?

It looks a cleaner fix is to put the m_buf and running check in sendObject, then remove the individual tests from call points. Would you agree?

from tinyos-main.

From mortenthansen on January 15, 2011 03:08:55
Yeah not sure what version I was looking at when I reported it. But think I was referring to line 211. As far as I can see all the "probe" code (the sendProbe function) does not seem to be used anymore.

I agree that moving the checks to the sendObject function would be the right thing to do.

from tinyos-main.

From [email protected] on January 21, 2011 17:41:40
I applied the bug fix, moving the check within sendObject().

from tinyos-main.