TOSSIM receive serial bug about tinyos-main HOT 4 CLOSED

From [email protected] on December 16, 2010 23:51:26
Doesn't the above fix repeat the problem on msg? Shouldn't it be

•   memcpy(newMsg, msg, sizeof(message_t));
  

•    uint8_t payloadLength = getHeader(msg)->length;
  

•    memcpy(getHeader(newMsg), msg, sizeof(serial_header_t)+payloadLength);
  

Phil

from tinyos-main.

From mortenthansen on December 17, 2010 01:44:33
I doubt your version will work.

The incomming packet (message_t* msg) is always from a serial forwarder which have no idea about the header alignment of TOSSIM messages and will then be aligned with msg->header. The new packet (message_t* newMsg) should have the prober alignment so on this message_t we should use getHeader(newMsg).

Does this make sense?

Morten.

from tinyos-main.

From [email protected] on December 18, 2010 01:42:30
It does. Sorry, it's been a long time since I saw this code; I forgot that the message coming in will be aligned at the beginning of the struct, not the proper header position. This actually suggests the typing of the functions is wrong, as technically it's not a message_t being passed in. But oh well.

I'll test your fix on Monday and check it in if it works for me.

from tinyos-main.

From [email protected] on December 22, 2010 00:30:50
I applied your fix.

from tinyos-main.