Giter Club home page Giter Club logo

Comments (7)

JamyGolden avatar JamyGolden commented on August 22, 2024

It sounds like a good idea to me! Does this look good to you? Once it's merged the various colorschemes will update with the comments. #23

from base16-putty.

clach04 avatar clach04 commented on August 22, 2024

It sounds like a good idea to me! Does this look good to you? Once it's merged the various colorschemes will update with the comments. #23

From a quick visual inspection on my phone your change appears to match my change from last year but I can't claim to have checked they match exactly. Out of curiosity why not take my commit?

from base16-putty.

JamyGolden avatar JamyGolden commented on August 22, 2024

Oh I didn't see you created a commit, however you haven't created a pull request so I'm not able to accept the commit as of right now since your commit only exists on your own branch.

If you create a pull request I'll accept your change and drop my PR.

from base16-putty.

clach04 avatar clach04 commented on August 22, 2024

I've no ego in this so, happy with your commit :-) Thanks for taking the time to respond/work on this!

from base16-putty.

JamyGolden avatar JamyGolden commented on August 22, 2024

I’d honestly prefer if your commit goes in vs mine. If you don’t want to create a pr would you be ok if I cherry pick your commit in my pr?

from base16-putty.

clach04 avatar clach04 commented on August 22, 2024

Opened #24 - looks like it applies cleanly

from base16-putty.

JamyGolden avatar JamyGolden commented on August 22, 2024

Nice and thanks! Just merged 😊

from base16-putty.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.