Giter Club home page Giter Club logo

Comments (7)

mmlb avatar mmlb commented on July 21, 2024

It seems that all we would usually need is editURL in config.toml and the learn theme does the right thing. But I tried it locally and it didn't work 😞, @felixwidjaja can you help us figure out whats going on?

from tinkerbell.org.

felixwidjaja avatar felixwidjaja commented on July 21, 2024

Hi @tstromberg @mmlb

Unfortunately, https://github.com/tinkerbell/tinkerbell-docs/ is based on MkDocs not Hugo (unlike the main site) :)

Fortunately, MkDocs suports Edit this page feature. Please test it out: https://github.com/tinkerbell/tinkerbell-docs/tree/Edit-this-page

Below is sshot of how it looks:
image

from tinkerbell.org.

mmlb avatar mmlb commented on July 21, 2024

Hi @tstromberg @mmlb

Unfortunately, tinkerbell/tinkerbell-docs is based on MkDocs not Hugo (unlike the main site) :)

🤦‍♂️ well that explains a lot 😄

Fortunately, MkDocs suports Edit this page feature. Please test it out: tinkerbell/tinkerbell-docs@Edit-this-page

I'm going to create a PR from that branch so we can get a preview of it.

from tinkerbell.org.

mmlb avatar mmlb commented on July 21, 2024

Oh and I just noticed that you are talking about docs.tinkerbell.org not tinkerbell.org @felixwidjaja! I still want to do that PR can we get similar Edit this page for tinkerbell.org?

from tinkerbell.org.

mmlb avatar mmlb commented on July 21, 2024

The split between tinkerbell.org and docs.tinkerbell.org continues to confuse and confound me!

from tinkerbell.org.

felixwidjaja avatar felixwidjaja commented on July 21, 2024

Sorry I was halucinating. But that docs. was still in need for that edit-this-page feature too :)
I'll investigate for the main site Hugo. I'm still trying to have it running in my localhost :(

from tinkerbell.org.

felixwidjaja avatar felixwidjaja commented on July 21, 2024

Here you go gents: https://github.com/tinkerbell/tinkerbell.org/tree/edit-this-page
image

from tinkerbell.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.