Comments (4)
from wordpress-plugin.
Version 2.2.2
I don't think it's necessary to send you the file as I did a bit of digging since last we spoke and I think I found the issue. It occured when PDF auto-gen thumbnails were forcibly removed and the plugin tried to optimize them (due to my implementation of an S3 bucket for migrating static files).
I gather the PDF thumbnails being images trigger the the plugins is-it-an-image test. Regardless of this assumption, should attachment information be stored as metadata, but not have a 'file' key & info, parse_wp_metadata()
in src\class-tiny-image.php
will cause this error.
While probably not an issue for many, I think it would still be better practice to explicitly check for the file
key rather than assuming it exists when the attachment's meta is an array. To this end I've gone ahead and added the check to parse_wp_metadata
and detect_duplicates
and will issue a pull request for your review.
from wordpress-plugin.
from wordpress-plugin.
Killer, let me know if there's any where I could improve it too (it didn't pass the Travis build and I'm wondering why as I didn't really do much :P )
from wordpress-plugin.
Related Issues (12)
- Getting a php syntax error in test/mock-tinypng-webservice/output.php HOT 5
- Re-optimization HOT 1
- Submit to Packagist HOT 1
- Function create_function() is deprecated since PHP 7.2; Use an anonymous function instead HOT 2
- Plugin installed as "wordpress-plugin" HOT 1
- EXIF data HOT 1
- [Feature request] Add Tiny_Plugin::compress() for general usage by devs HOT 2
- [Feature request] Add WP CLI commands HOT 2
- [Feature request] webp conversion HOT 1
- Option to bulk optimize images >=200px only HOT 1
- [Feature Request] Optimize images out side of WordPress Media Upload HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wordpress-plugin.