Comments (7)
timtrinidad
commented on August 28, 2024
1
Creating a fork and opening a pull request from that fork is standard practice for contributions to open source projects. This allows anyone to propose changes to OSS without being added as a collaborator.
Here's an example - this is a PR into the kubernetes repository from a user-cloned fork: kubernetes/kubernetes#107658
from chrome-extension-force-new-tabs-to-main-window.
timtrinidad
commented on August 28, 2024
Good catch - thanks! This repo should allow PRs - is it not allowing you?
from chrome-extension-force-new-tabs-to-main-window.
meadowsjared
commented on August 28, 2024
Tim,
Thank you for getting back to me sir!
Ya I'm sorry, I tried to submit a PR already but it's throwing this error:
[image: image.png]
I believe you need to add me here:
https://github.com/timtrinidad/chrome-extension-force-new-tabs-to-main-window/settings/access
to allow me to submit a PR for your review.
I do web development work for my main job (I've been doing it for about 20
years or so) so I'm happy to help out. I find your extension invaluable as
I use addon's for games that I play which open stat tabs, but it's VERY
annoying because it will often open it over the top of a video I'm watching
on my 2nd monitor (if that was the last tab I interacted with).
In addition to helping you solve those two issues I've found, I was hoping
to submit a third PR to add a feature where you can both toggle which
window is main just by clicking the icon, as well as adding a "highlighted
icon" to that window, to make it very simple for the user to understand
which window is currently set to being the main window. I already have
this working, but I still need to get the icon stuff working, I'll try and
get to that in the next couple of days maybe.
Please let me know if you have any questions, thanks again for getting back
to me!
…-Jared Meadows
On Wed, Jan 19, 2022 at 12:15 PM timtrinidad ***@***.***> wrote:
Good catch - thanks! This repo should allow PRs - is it not allowing you?
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMF2V7SAPMJGHLH46PHJWDUW4LV7ANCNFSM5MK4IW6A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
<timtrinidad/chrome-extension-force-new-tabs-to-main-window/issues/1/1016832547
@github.com>
from chrome-extension-force-new-tabs-to-main-window.
timtrinidad
commented on August 28, 2024
The image didn't come through. Are you not able to create a fork, make your changes there, and then open up a PR from your fork to this repo?
from chrome-extension-force-new-tabs-to-main-window.
meadowsjared
commented on August 28, 2024
I could create a fork, but if I did that, that would only create a separate repo and when I submit my PR, it would go to my won repo, which would defeat the purpose of me trying to help yours, rather than publishing it myself and creating yet another chrome web store entry (which feels spammy). Here is the text from the image:
when I ran this command:
git push --set-upstream origin current-window-main-menu
ERROR: Permission to timtrinidad/chrome-extension-force-new-tabs-to-main-window.git denied to meadowsjared.
fatal: Could not read from remote registry.
Please make sure you have correct access rights
and the repository exists.
from chrome-extension-force-new-tabs-to-main-window.
meadowsjared
commented on August 28, 2024
ah ok, sorry about that, I'll do that then, I'm accustomed to just being added to the repo as we've been doing that at work for years, I'll give that a shot though!
from chrome-extension-force-new-tabs-to-main-window.
meadowsjared
commented on August 28, 2024
ok please let me know if you have any issues with the PR
from chrome-extension-force-new-tabs-to-main-window.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chrome-extension-force-new-tabs-to-main-window.