Hi, could I ask why this commit reverted about rootlessjamesdsp HOT 4 CLOSED

Hi, the commit was not reverted. Your changes should still be in the code base.

I did some code refactoring lately, so I moved your code from the MainActivity.kt into BaseActivity.kt (https://github.com/ThePBone/RootlessJamesDSP/blob/062cce2d9ccabf2aa30a23db4ad2cad5c1fe7dff/app/src/main/java/me/timschneeberger/rootlessjamesdsp/activity/BaseActivity.kt#L48). By putting it into BaseActivity, it will ensure that the 'Remove from recents' code is triggered even when other activities than MainActivity are launched. All activities inherit from the BaseActivity class to centralize shared code.

from rootlessjamesdsp.

But the switch function in the app behaviour is gone

from rootlessjamesdsp.

Oops. I found the problem. It looks like the switch function is only visible in rootless builds and invisible in root builds because of some changes and rearrangements I made for the settings screen.

Commit 20c1d2c (included in version 1.4.3) fixes this issue. Root build APK: https://nightly.timschneeberger.me/rootlessjamesdsp-rootfull/JamesDSP-v1.4.3-30-root-full-universal-release-signed.apk

from rootlessjamesdsp.

thx, the problem was fixed

from rootlessjamesdsp.