Comments (7)
I noticed this problem as well when I was looking at the javadoc. This is more
than
just a bug since you cannot even create a valid news sitemap as the previous
poster
said. This means the classes related to google news sitemaps are useless as
is.
Please address this because you cannot say that your tool supports this type of
sitemap when it actually does not.
Original comment by [email protected]
on 13 Apr 2010 at 9:58
from sitemapgen4j.
This does appear to be a real problem. Unfortunately, I don't use News
Sitemaps, so
I may not be able to fix this in a timely manner. Patches welcome.
Original comment by [email protected]
on 14 Apr 2010 at 1:13
- Changed state: Accepted
- Added labels: Priority-High
- Removed labels: Priority-Medium
from sitemapgen4j.
OK I have created a patch to fix this. What is the process to submit the patch?
I have attached a zip file containing the code.
Here is a quick list of the changes:
Added classes:
Acess - enum class for valid access values in the google news sitemap
Genre - enum class for valid genre values in the google news sitemap
Changes classes:
GoogleNewsSitemapUrl - add new fields for new tags, with getter methods and
setters
in the Options class
GoogleNewsSitemapGenerator - changed rendered to render new tags
GoogleNewsSitemapUrl - added new test "testFullOptions" to test all new tags
Note: the changes should not affect the behaviour of any existing code that
uses
these classes in any way
Original comment by [email protected]
on 14 Apr 2010 at 11:06
Attachments:
from sitemapgen4j.
Thanks for posting this. I think that these new additions to Google's algorithm
will make online the <a href="http://www.freesitemapsubmit.com/">XML sitemap
generator</a> tools even more important.
Original comment by [email protected]
on 9 May 2011 at 8:22
from sitemapgen4j.
Any chance the patch will be accepted?
Original comment by [email protected]
on 8 Nov 2012 at 5:35
from sitemapgen4j.
I noticed that this issue is still not resolved and the patch has not been
accepted. The News Sitemap is unusable without it, any chance this can still
be accepted?
Original comment by [email protected]
on 14 Oct 2014 at 4:33
from sitemapgen4j.
Could you please open a pull request with the fix at
https://github.com/dfabulich/sitemapgen4j ?
Original comment by [email protected]
on 20 Mar 2015 at 10:05
from sitemapgen4j.
Related Issues (19)
- gzip method is package-protected
- AbstractSitemapUrlRenderer should take care of escaping entities & and < in URLs HOT 1
- GoogleVideoSitemapUrl.Options misses the field HOT 3
- Missing xmlns:xsi and xsi:schemaLocation namespaces HOT 1
- jdom integration HOT 1
- Ability to change output to other outputstreams, strings, etc.
- wsg.writeSitemapsWithIndex() HOT 6
- Make This App Engine Friendly HOT 1
- GZip and AutoValidate builder options are not compatible HOT 1
- UrlUtils.checkUrl as option
- Missing IMAGE:IMAGE tag HOT 3
- Cannot add URL which does not start with base URL
- sitemap index limit error
- Usage of WebSitemapUrl.class cannot be compiled with Java 1.7.0_25
- URL using non ASCII characters [utf-8 support] HOT 1
- Support for mixed video and image sitemaps? HOT 2
- video:expiration_date missing HOT 1
- Allow WebSitemapGenerator to use Commons-VFS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sitemapgen4j.