Giter Club home page Giter Club logo

Comments (15)

Titaniumtown avatar Titaniumtown commented on August 16, 2024

Thanks! I will look into this!

from hdr-plus.

brotherofken avatar brotherofken commented on August 16, 2024

Actually, if input file has DNG format, then the following should be enough:

  1. Obtain libexiv2:
apt install libexiv2-dev
  1. Somewhere in CMakeLists.txt add:
find_package(Exiv2 REQUIRED)
  1. Then read image dimensions as follows:
const Exiv2::Image exiv_image = Exiv2::ImageFactory::open(path);
exiv_image->readMetadata();
const Exiv2::ExifData exiv_data = image->exifData();
// Now read dimensions of Exif.Image
// Also there are chance that you have to choose another IFD, like "Exif.SubImage1.ImageWidth". 
// That may happen if DNG contains a JPEG thumbnail
const int width = exiv_data["Exif.Image.ImageWidth"].toLong(); 
const int height = exiv_data["Exif.Image.ImageHeight"].toLong();
// Also you have to read and use and consider during processing:
// * WhiteLevel and BlackLevel
// * CFAPattern
// * AsShotNeutral, ColorIlluminant1/ColorIlluminant2
// * Exif.Image.Orientation
// * and many more

Thus topic of this issue is wider than just reading of image dimensions.

Thank you!

from hdr-plus.

Titaniumtown avatar Titaniumtown commented on August 16, 2024

I am creating a prototype! Thanks for the info, very useful!

from hdr-plus.

brotherofken avatar brotherofken commented on August 16, 2024

Hi! Any progress on this? Can I help you somehow?

from hdr-plus.

brotherofken avatar brotherofken commented on August 16, 2024

Also, if you are looking for more bursts, I would recommend to use HDR+ dataset: https://hdrplusdata.org/

Images there have different bayer patterns, so you have to support them in demosaicing. White balance differs too.

from hdr-plus.

Titaniumtown avatar Titaniumtown commented on August 16, 2024

Sorry I have been really busy lately; I am sorry I have not provided updates as I have not had time to work on it. I might possibly be able to work on it later this week!

from hdr-plus.

Titaniumtown avatar Titaniumtown commented on August 16, 2024

I have been trying to implement it; no success though. Sorry for the lack of response. Any help would be appreciated!

from hdr-plus.

brotherofken avatar brotherofken commented on August 16, 2024

Could you please publish a branch with your current progress? Any progress and even if the code not clean.
Unfortunately I'm very limited in time :-( but hopefully will find time to look at the code on weekend.

from hdr-plus.

Titaniumtown avatar Titaniumtown commented on August 16, 2024

It fails to build currently; but I will post it later today!

from hdr-plus.

Titaniumtown avatar Titaniumtown commented on August 16, 2024

Sorry for not posting the code I think I know what is wrong with it!!

from hdr-plus.

Titaniumtown avatar Titaniumtown commented on August 16, 2024

Ok I uploaded the code at: https://github.com/Titaniumtown/hdr-plus

from hdr-plus.

brotherofken avatar brotherofken commented on August 16, 2024

Ok I uploaded the code at: https://github.com/Titaniumtown/hdr-plus

#36

from hdr-plus.

brotherofken avatar brotherofken commented on August 16, 2024

Thank you for fast merge, @Titaniumtown !

Also, there are imperfection in my implementation. I do not crop 'masked pixels' from RAW, and now they appear in the output. :-(

The problem is located here:
https://github.com/timothybrooks/hdr-plus/blob/master/src/InputSource.cpp#L34

I'll fix that and make another PR shortly.

from hdr-plus.

Titaniumtown avatar Titaniumtown commented on August 16, 2024

Bump! Are you going to make a pull request?

from hdr-plus.

brotherofken avatar brotherofken commented on August 16, 2024

Oh, sorry for that. :-(
I'll try to look at this on a weekend.
The thing is to copy pixels according to ActiveArea Raw tag.

from hdr-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.