Giter Club home page Giter Club logo

Comments (6)

nathanklick avatar nathanklick commented on June 30, 2024 1

@timo-reymann Thank you for getting these changes approved and a new release issued. We depend on this in several deployment CI pipelines and the lack of directory entries in the zip file was causing some pain for one of applications.

from deterministic-zip.

nathanklick avatar nathanklick commented on June 30, 2024

Pull request submitted:

from deterministic-zip.

timo-reymann avatar timo-reymann commented on June 30, 2024

Hi @nathanklick,

thanks for contributing. Changes look good so far but i will need to take a closer look everything still works etc.

As i am currently on vacation, i will do this around next week.

Cheers, Timo :)

from deterministic-zip.

nathanklick avatar nathanklick commented on June 30, 2024

@timo-reymann Hope you had a good vacation! Do you have an ETA on your thorough testing and review? If you accept these changes, would you mind cutting a new release version?

from deterministic-zip.

timo-reymann avatar timo-reymann commented on June 30, 2024

Heya @nathanklick,

thank you! :)

I will review it until 29.08, maybe 28.08 if everything goes well.

After that i will create a new release :)

from deterministic-zip.

timo-reymann avatar timo-reymann commented on June 30, 2024

Heya,

took a closer look at the changes. Merged it and released 1.2.0 :)
Thanks for contributing! 🥳

Cheers
Timo

from deterministic-zip.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.