timfish / forge-externals-plugin Goto Github PK

Hello,
I found out about this package via this issue from the ElectronForge page that I filed:

electron/forge#2949

If you read down a bit, your plug-in fixes the case when I package a native dependency invoked from the main process. However, if I move the code to the renderer.ts process, it cannot find serialport (warning from the browser); nor if I import serialport from a forked process from main, it also cannot find it (no native module exists...).

I only filed an issue with a simple bug because my main application is several years old and has grown quite a bit, but I can include portions if it would help you debug?

E.g., my webpack.main.config.js contains this:

module.exports = {
  /**
   * This is the main entry point for your application, it's the first file
   * that runs in the main process.
   */
  entry: {
    'index': './src/main/index.ts',
    'worker-thread': './src/framework/worker-thread.ts',
    'worker-thread-lpm01a': './src/framework/device-manager/lpm01a/worker-thread.ts'
  },
  output:{
    filename: '[name].js',
  },
  module: {
    rules: require('./webpack.rules'),
  },
  // Need this so that we can build "worker-thread" which has Vue/Pug in it
  plugins: plugins,
  resolve: {
    extensions: ['.js', '.ts', '.jsx', '.tsx', '.css', '.json'],
  },
  externals: {
    serialport: "serialport",
  }
};

And as you can probably guess, worker-thread-lpm01a is forked from worker_thread, which is forked from index (main) and then imports serialport.

Hi,
I want to use the plugin with a @Scoped native package. In this case, it does not work. yarn start works fine but the packaged version does not contain the scoped native package.
Thanks.

Hi,

I'm using electron-forge 6.1 with webpack and native modules.
I found my native module doesn' t included in the package, so I installed this plugin.
It was loaded but does nothing.

I read Writing Plugins and turned out that getHook may be deprecated and changed to getHooks. Changing getHook to getHooks as follows fixed the probrem.

  getHooks() {    
    return {
      resolveForgeConfig: this.resolveForgeConfig,
    };
  }

This is very tiny change, so I write to here. If you prefer, I can send a PR.

Best regards,

@timfish

I found an cenario where scoped subdependencies of serialport(Eg: @serialport/parser-byte-length) wasn't included on node_modules after forge package.

Please review the change adding the split case of foundModules so we could publish an fix version.