Comments (8)
@Jeff-Lewis I'm looking to patch a couple of internal Bluebird functions which are called by all public methods, rather than patch every Bluebird method individually as Sequelize does.
Actually, the aim is to move Sequelize over to cls-bluebird
once this work is complete.
I'm not 100% sure that Sequelize's shim works completely in all cases. I've had occasional CLS context loss in some weird edge cases with Sequelize's shim (though there were other moving parts involved, so can't conclusively say that it's a problem with Sequelize).
The main thing actually is to write a comprehensive test suite to make sure it's 100% bullet-proof, and I'm on the case with that now.
from cls-bluebird.
@overlookmotel Thanks for picking up cls-bluebird. In order to bring it up to speed with Bluebird v3, will it be similar to what Sequelize does?
from cls-bluebird.
hey ,
when do you think it will be published ?
it will help my very much
from cls-bluebird.
@ravivaxonite Can't really give a prediction I'm afraid. It's complicated stuff and I have other work going on which is unpredictable.
from cls-bluebird.
dont looking for a commit :)
some assumption ?
from cls-bluebird.
Maybe a month. But I make no promises! (no pun intended)
from cls-bluebird.
@Jeff-Lewis I've changed my mind! I am now proposing to adopt a patch similar to Sequelize's. See #13.
from cls-bluebird.
Fixed in v2.0.0
from cls-bluebird.
Related Issues (13)
- Enable Travis HOT 2
- `Promise.reduce()` broken in bluebird v2 HOT 2
- Change approach to how this patch works internally HOT 7
- LICENSE file HOT 2
- await is not working :( HOT 4
- cls and promisify HOT 2
- RangeError: Maximum call stack size exceeded HOT 5
- Broke with Bluebird 3.5.1
- Does cls-bluebird also work with cls-hooked?
- how to run test? HOT 2
- Clarifying purpose of cls-bluebird HOT 3
- Re-write of tests HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cls-bluebird.