Comments (5)
Hi @johnboiles -- good call, it hadn't occurred to me that this log output could be confusing, but you're totally right! We'll look into whether this can be clarified at all, but know that this is currently expected behavior.
In case you're curious about why this is happening (feel free to ignore this if not):
This is a side-effect of the way we do fast builds. We tar up all your files ourselves, in a format that matches the way we want to un-tar them, and generate a Dockerfile and run it with our homemade tar file as the build context.
So if you call .add(/path/to/source, /path/in/container)
, we create a tar archive such that all the files in /path/to/source
live in the directory /path/in/container
. The Dockerfile we generate just has a single add statement: ADD . /
-- but because of the way we tar'd everything up, this will unpack everything into the right place on the container.
Hope that makes sense! (If it doesn't and you're still curious about how this all works under the hood, I'm happy to answer more questions.)
from tilt.
Thanks for the explanation! Feel free to close the ticket if you think thatβs appropriate.
In my case I had a typo in my run command that made it appear like my files werenβt getting copied in. The ADD log line seemed to confirm this hypothesis so I ended up burning a little time checking that files were copied before I found the real issue
from tilt.
Threw something together -- turns out it's more annoying than it should be to print that ADD
statement with something like
# we tarred up everything so it ends up in the right place in your container, promise
ADD . /
π so, seems like this is the next best thing (added some logging that you can get by running tilt
with the --verbose
flag). @johnboiles does this seem like it would have been helpful to have?
βββ€ Building: fe βββββββββββββββββββββββββββββββββββββββββββββββ
STEP 1/2 β Building from scratch: [gcr.io/windmill-public-containers/servantes/fe]
β Tarring contextβ¦
β /Users/maia/code/prog/src1 --> /path/in/container/1
β /Users/maia/code/prog/src2 --> /path/in/container/2
β Created tarball (size: 24 MB)
β Building image
β [1/6] FROM docker.io/library/golang:1.10
β [2/6] RUN apt update && apt install -y unzip time make
β [3/6] RUN wget https://github.com/google/protobuf/releases/download/...
β [4/6] RUN go get github.com/golang/protobuf/protoc-gen-go
β [5/6] ADD . /
β [6/6] RUN go install github.com/windmilleng/servantes/fe
...
If so, we'll add it in. If not, we'll drop it :)
from tilt.
Maybe it would help to make it more clear that this is docker output, for debugging/showing progress, and not "tilt" output? WDYT?
from tilt.
We added some code to at least give a little more visibility into what's going on if you run tilt in --verbose
mode -- going to close this issue. Thanks for the report!
from tilt.
Related Issues (20)
- New issue
- New issue
- New issue HOT 1
- Add stopResourcesBeforeRun to local_resource
- service grouping across namespaces is wrong
- custom_build_with_restart dosnt work for env and dir params HOT 2
- tilt ci waits on a local job yaml, but fails to wait for a helm installed job
- release web assets as part of release
- Tilt can't find object using fully qualified K8s Object Selector HOT 4
- Docker Compose with profiles fail to start HOT 1
- workload_to_resource_function does nothing for resources from docker_compose or dc_resource
- dc_resource's new_name parameter causes Tiltfile warnings if docker depends_on is used with that resource
- Tilt does not support incremental builds
- Tilt syncback does not work on WSL2 (Linux subsystem for Windows) HOT 3
- tilt down does not kill Tilt process HOT 1
- Support Tiltfile args with `tilt enable` HOT 1
- Docker compose profiles set to * doesn't work HOT 4
- Tilt tries to push to docker registry when used with rootless docker + minikube HOT 4
- livenessProbeProbe returns Connection Refused HOT 1
- [Bug] Unable to call commands on host from within `workload_to_resource_function` method HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tilt.