Comments (2)
I suspect that there are at least two issues here: a surface issue that the tk-sign app isn't able to time out on failed communications, and a root cause issue which is somewhere lower than that. I'd be happy to run these tests again if there's a debug output that can be enabled that would be more useful.
from tkey-ssh-agent.
I have been investigating USB related issues lately and been able to come to a conclusion.
You are right that there are two issues.
The major one is that the CH552 can drop bytes in certain circumstances in the direction of UART -> USB, i.e., TKey to client.
The second, one is that the implementation of the client programs using readfull()
, which does not have any timeout and will read until the buffer is full - and if a byte is dropped it will never come and then you have a hanging client program.
I have a fix for it in this PR which more or less just protects the input/output buffers and making sure interrupts are not fiddling with the indices of said buffers.
I'm not able to reproduce the issue after the fix.
So, if you want to try it. Feel free, otherwise I will close this issue now.
from tkey-ssh-agent.
Related Issues (20)
- LGPL licenses on libraries HOT 2
- Break out device libraries
- Add Windows support to tkey-ssh-agent
- windows: getting "access denied" notification if named pipe already exists HOT 3
- Break out Go packages HOT 4
- Break out device apps HOT 1
- Break out client apps
- Break out ssh-agent HOT 3
- Use with gpg-agent / scdaemon HOT 2
- Question: Why use `RM=/bin/rm` in certain places and not others? HOT 4
- detect os when building to support darwin HOT 1
- Update go-serial to build for darwin HOT 3
- Server use-case with no touch
- Embed tagged signer in tkey-ssh-agent HOT 2
- Did 0.0.6 release get re-tagged? HOT 13
- Use Goreleaser to build releases
- Building MSI package in CI fails HOT 1
- Convert man page to scdoc
- Handle if the socket exists when a service tries to start tkey-ssh-agent
- Linux: Document pinentry and Desktop Notifications HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tkey-ssh-agent.