Giter Club home page Giter Club logo

Comments (4)

tillarnold avatar tillarnold commented on June 20, 2024

The best solution is to do a try/catch for requiring react-tools and throw an error if it is not installed, hopefully with a helpful error message on how to fix the problem

This is a good solution. I'll do that.

I initially wanted to add react-tools (without a version number) as a peerDependencie. But then it would not work when react-tools is installed globally, or would it?

from grunt-jsxhint.

Munter avatar Munter commented on June 20, 2024

Peerdecpendencies are are real pain to work with. We've been wrapping compilers like this in assetgraph for years, and when we used peer dependencies there was always something broken either in a dev setup with linked dependencies, with globally available modules or even worse, in production.

Just move react-tools down to a dev-dependency so you can still run all tests on this repository when developing

from grunt-jsxhint.

tillarnold avatar tillarnold commented on June 20, 2024

Ok I'll do that.

from grunt-jsxhint.

Munter avatar Munter commented on June 20, 2024

https://www.npmjs.org/package/accord might be an interesting project for this. Allthough there is no jsx support yet. I think we need it for assetgraph pretty soon, so I'll probably send a pull request to add it to accord.

I'll see if I can remember to trickle it back here as well when it's done

from grunt-jsxhint.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.