Giter Club home page Giter Club logo

Comments (3)

springmeyer avatar springmeyer commented on May 24, 2024

ddc7a78 fixes for me, but I wonder if the remaining counter is actually not synced correctly. Also it seems like passing next as a callback to localizeCartoURIs would be the more correct and predictable approach.

@ansis - can you take a look and let me know if you see the same failures before ddc7a78 and if ddc7a78 fixes?

from millstone.

ansis avatar ansis commented on May 24, 2024

Yeah, it looks like that should fix it. Does this look clearer? https://github.com/mapbox/millstone/compare/small-next-cleanup

from millstone.

springmeyer avatar springmeyer commented on May 24, 2024

that does, thank you. Could you queue up as a pull (after making sure the texts pass for you)?

from millstone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.