v. 2.18.2 broken on macOS 11: `prng.cc: error: chosen constructor is explicit in copy-initialization` about tiledb HOT 13 CLOSED

UPD. Switching from Apple to LLVM clang fixed the build on macOS 11.

from tiledb.

Hi @barracuda156, sorry for the delay. We have made some progress to find a machine where we might be able to reproduce the issue. @ypatia will get back to you once we make more progress.

from tiledb.

Thanks for the report. As we regularly build on macOS too, what is the compiler you used and what is its version?

from tiledb.

@eddelbuettel Thank you for responding. Build log from CI can be found here: https://github.com/macports/macports-ports/actions/runs/7153192710/job/19479362426?pr=21708

  DEBUG: Starting logging for tiledb @2.18.2_0
  DEBUG: macOS 11.7.10 (darwin/20.6.0) arch i386
  DEBUG: MacPorts 2.8.1
  DEBUG: Xcode 13.2.1, CLT 13.2.0.0.1.1638488800
  DEBUG: SDK 11
  DEBUG: MACOSX_DEPLOYMENT_TARGET: 11.0

It uses Xcode clang at the moment.

The error might be specific to Xcode clang of Xcode 13 (and earlier, perhaps): identical portfile builds fine on macOS 12 and 13 with their clangs (tested on CI), as well as on 10.6 with gcc13 (tested locally).

from tiledb.

Please show clang++ --version if you can access it.

from tiledb.

Please show clang++ --version if you can access it.

Cannot check locally, but from CI log:

  -- The C compiler identification is AppleClang 13.0.0.13000029
  -- The CXX compiler identification is AppleClang 13.0.0.13000029

from tiledb.

Makese sense. I tried here with clang-17 and had no issues. So ok to close as non-issue?

from tiledb.

@eddelbuettel Provided there is no requirement from your end to support Xcode clang, sure, we can close this. (In Macports we can switch to LLVM clangs whenever needed, no big deal.)

from tiledb.

@eddelbuettel I do not want to open another issue about this, but could you please take a look? On Catalina tiledb 2.18.2 still fails with LLVM clang-16:

/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_databases_tiledb/tiledb/work/TileDB-2.18.2/tiledb/common/random/prng.cc:72:12: error: chosen constructor is explicit in copy-initialization
    return {};  // RVO
           ^~
/opt/local/include/libcxx/v1/random:2110:14: note: explicit constructor declared here
    explicit mersenne_twister_engine(result_type __sd = default_seed)
             ^
1 error generated.
. . .
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_databases_tiledb/tiledb/work/TileDB-2.18.2/tiledb/sm/array_schema/array_schema.cc:58:
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_databases_tiledb/tiledb/work/TileDB-2.18.2/tiledb/../tiledb/type/apply_with_type.h:43:43: error: 'T' does not refer to a value
concept TileDBFundamental = std::integral<T> || std::floating_point<T>;
                                          ^

Complete log: https://build.macports.org/builders/ports-10.15_x86_64-builder/builds/165141/steps/install-port/logs/stdio
It also fails on every earlier macOS when built with Clang.

Notice that on macOS 11 the same clang-16 builds it successfully: https://build.macports.org/builders/ports-11_x86_64-builder/builds/136088/steps/install-port/logs/stdio

from tiledb.

I may have stated that a few times already but I only work on Linux, so I have to pass. (And I did just build 'everything' with clang-17 a few days ago as a test.)

from tiledb.

@eddelbuettel Got it, sorry. (And your help is always greatly appreciated.)

from tiledb.

I've assigned @KiterLuc who can perform a triage and might assign to another engineer to assist @barracuda156 .

from tiledb.

@KiterLuc Thank you!

from tiledb.