Empty invalid and not_found_in_database translations for zh-TW about devise-i18n HOT 7 CLOSED

This repo's English strings are a copy of devise's English strings. Strings in other languages should say the same thing as the English strings, unless there's a good, language-specific reason not to.

from devise-i18n.

Could you clarify by "should say the same thing as the English strings"? Did you mean other languages should also display the English version of the strings?

from devise-i18n.

If I use devise-i18n without adding my customized zh-TW yaml, when I failed to login the flash message will show translation missing: zh-TW.devise.failure.sales_user.not_found_in_database.

But if I add a devise.views.zh-tw.yml and fill in a string for key not_found_in_database, then the flash will properly display the string.

Does this mean we should not have empty keys for translations in the gem?

from devise-i18n.

Could you clarify by "should say the same thing as the English strings"?

The meaning of the message should be the same in all languages, unless there is a reason for them not to be.

If I use devise-i18n without adding my customized zh-TW yaml, when I failed to login the flash message will show translation missing: zh-TW.devise.failure.sales_user.not_found_in_database.

Some languages are not complete in this project. If you want to contribute translations they would be very welcome. Short of doing that, your options are:

• Defining a custom file, like you did.
• Defining a fallback language, so that the messages show in e.g. English if they are not available in your chosen language.
• Live with the missing translations.

from devise-i18n.

Gotcha. I've contributed to the zh-TW translations for these two strings on localeapp. Would be great to see them in the next pull 😃

from devise-i18n.

Done in ed81f29. 謝謝!

from devise-i18n.

Thanks!

from devise-i18n.