Comments (3)
Hi @Kagetsuki ,
I like the idea of localized views but think your implementation can be improved :
- there should be no additional translations to be added to the locale files - devise-i18n is foremost a translation of the original
yaml files. - maybe create a generator for the views (ex: rails generate devise:i18n-views) so that they can be implemented optionally.
While I'm at it, any chance of completing the "ja" translations? :)
from devise-i18n.
OK, so in other words having a different gem with the localized views and the supplemental translations for those views would be preferable? Just including the gem could override the views and provide the translations. Having a rake task to copy over the localized views to a local app would be a good addition too I'd think.
And yes, I'll complete the JA translations.
from devise-i18n.
☆Translations completed
from devise-i18n.
Related Issues (20)
- Apply devise changes in 4.5.0 HOT 1
- Test that rendering devise-i18n + en == devise
- Missing "errors.messages.taken" key HOT 1
- Merge Hindi :hi Language File HOT 1
- Update for devise 4.6 HOT 2
- Fix `rake release` on Ruby 2.5+ HOT 1
- shared error message downcases model
- Missing translation HOT 1
- Flash messages not localized HOT 2
- Wrong scoped views generation? HOT 6
- [question] How to set the Devise locale for current request (in a thread safe manner)? HOT 5
- add "confirmed" to i18n HOT 4
- Missing message when mail is unconfirmed in mailer email_changed HOT 4
- Missing inactive account translation missing HOT 1
- Possibly missing string HOT 2
- Missing partial string `Reset password token` HOT 2
- Merge Esperanto :eo language file HOT 1
- Do devise generated views and locales have to be renamed? HOT 1
- Undefined method 'user_url' HOT 1
- Prepare for Devise 4.9.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devise-i18n.