Giter Club home page Giter Club logo

Comments (2)

hadley avatar hadley commented on June 1, 2024

We need to figure out the semantics — I think probably it should using matching not equality. And maybe it should only be vectorised in its first argument? Maybe it should just be this?

na_if <- function(x, na) {
 x[vec_in(x, na)] <- NA
 x
}

Which makes it a special case of case_in(): case_in(x, y ~ NA)

from funs.

DavisVaughan avatar DavisVaughan commented on June 1, 2024

Regarding na_if() being match-like, we document that na_if() is like SQL NULLIF(), and that uses equality. And a few people use it that way (after looking at GitHub). So it is probably best to leave it like this and promote some other way to do match-like replacement with NAs. See my full analysis in: tidyverse/dplyr#6329 (comment)

from funs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.