Giter Club home page Giter Club logo

Comments (3)

DavisVaughan avatar DavisVaughan commented on June 25, 2024

Actually don't do this. To be consistent everywhere we'd have to make forge() do the same thing, but it is S3 on the preprocessor argument. This would mean we would need to do UseMethod("forge", "preprocessor") because it would then be the second arg. This wouldn't be the end of the world but it likely more confusing that it would need to be.

from hardhat.

DavisVaughan avatar DavisVaughan commented on June 25, 2024

Hmm, maybe do this with scream() and shrink() because they return new_data back as the output, but don't do it with forge() because it returns a more complicated object back (not pipeable anyways).

Nah, better to be consistent throughout

from hardhat.

github-actions avatar github-actions commented on June 25, 2024

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

from hardhat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.