Giter Club home page Giter Club logo

Comments (3)

tianyu0207 avatar tianyu0207 commented on August 16, 2024

Hello!

In Equation 6, as shown bellow, you calcule the L_{s} by:

image

However, in train.py, you calcule loss_abn and loss_nor by doing:

loss_abn = torch.abs(self.margin - torch.norm(torch.mean(feat_a, dim=1), p=2, dim=1))
loss_nor = torch.norm(torch.mean(feat_n, dim=1), p=2, dim=1)

loss_um = torch.mean((loss_abn + loss_nor) ** 2)

Why you used the torch.abs and squared (loss_abn + loss_nor)? This don't match the equation. Maybe some trick to converge?

Regards!

Hi Sorry for the late reply. Doing this shows better convergence. it did the same thing as the equation in the paper.

from rtfm.

wjtan99 avatar wjtan99 commented on August 16, 2024

@tianyu0207 Can you give a reference to why this implementation is the same as Equation (6), or give proof?
Thanks a lot.

from rtfm.

coranholmes avatar coranholmes commented on August 16, 2024

Hi, I have the same question. Have you got any idea on this?

from rtfm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.