Giter Club home page Giter Club logo

Comments (11)

jferris avatar jferris commented on September 24, 2024

I'd love to have this in capybara-webkit, but I would want tests. Accurately testing the contents of the image without being brittle is difficult, but you could make sure a file with the correct name is generated with the correct width and height. I'm fine introducing a test dependency on imagemagick or something for that.

from capybara-webkit.

oriolgual avatar oriolgual commented on September 24, 2024

I'm also really interested in this, can I help in any way?

from capybara-webkit.

oriolgual avatar oriolgual commented on September 24, 2024

Just seen this si already merged! Shouldn't the issue be closed?

from capybara-webkit.

nicholaides avatar nicholaides commented on September 24, 2024

Yes, it should. Closing.

from capybara-webkit.

kmarsh avatar kmarsh commented on September 24, 2024

I see this was added, and the render method is in the code, but how does one use in within the context of a Cucumber step?

from capybara-webkit.

oriolgual avatar oriolgual commented on September 24, 2024
page.driver.render 'file_name', options

You can check the options at the spec: https://github.com/thoughtbot/capybara-webkit/blob/master/spec/driver_rendering_spec.rb

from capybara-webkit.

pusewicz avatar pusewicz commented on September 24, 2024

Hmm, I seem to be getting Capybara::Driver::Webkit::WebkitInvalidResponseError error when I try to render the page, although the specs pass for capybara-webkit.

from capybara-webkit.

nicholaides avatar nicholaides commented on September 24, 2024

@pusewicz I'm pretty sure I've gotten that before. It may have been from trying to render before navigating to a page. You could test to see if a page is loaded buy doing save_and_open_page.

from capybara-webkit.

pusewicz avatar pusewicz commented on September 24, 2024

@nicholaides yes, the page gets loaded and save_and_open_page show correct stuff. I still get the error.

from capybara-webkit.

dbalatero avatar dbalatero commented on September 24, 2024

@pusewicz I get that error as well. Did you ever find a fix?

from capybara-webkit.

pusewicz avatar pusewicz commented on September 24, 2024

@dbalatero No, sorry.

from capybara-webkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.