Third party dependencies fail to add with please_go about please HOT 4 CLOSED

I think the codelab should be using ///go//tools:please_go rather than ///go//tools/please_go. One uses the pre-built binary, and the other builds it from source.

Though these days you can just use puku which should resolve this all for you with puku sync -w:
https://github.com/please-build/puku

from please.

I wonder if this is related to tools/please_go/packageinfo/packageinfo.go using slices here because it looks like slices only supports go 1.21 and higher and in my please project I'm using go 1.20.14?

// In third_party/go/BUILD
go_toolchain(
    name = "toolchain",
    version = "1.20.14",
)

Is it the case that please_go only supports go 1.21 and higher?

from please.

Yes, this seems to be it! When I change my please go toolchain to go 1.22.1 things work:

// In third_party/go/BUILD
go_toolchain(
    name = "toolchain",
    # version = "1.20.14",
    version = "1.22.1",
)

now I can run

zsh> plz run ///go//tools/please_go -- get github.com/stretchr/[email protected]


go_repo(module="github.com/stretchr/objx", version="v0.5.0")
go_repo(module="gopkg.in/yaml.v3", version="v3.0.1")
go_repo(module="gopkg.in/check.v1", version="v0.0.0-20161208181325-20d25e280405")
go_repo(module="github.com/stretchr/testify", version="v1.8.2")
go_repo(module="github.com/davecgh/go-spew", version="v1.1.1")
go_repo(module="github.com/pmezard/go-difflib", version="v1.0.0")

But I still need to get please to work with go 1.20.14. :-(

I am currently running please 17.8.3. Does that only support go1.21 and higher? And if so how can I get please_go to work with go 1.20.14?

Thanks!

from please.

This seems to be an issue with please_go here as slices wasn't added to go until 1.21 but that PR lists go 1.20?

from please.