Feature Request: Moons shouldnt generate as planets about seworldgenplugin HOT 24 CLOSED

That should not happen, can you look into the configuration file in the worlds folder, and see, if the moons actually get copied over?
The way the plugin works is, it has all planets in one list. And then, it filters them out by blacklisted, moons etc. The ones that remain will be used as planets.

from seworldgenplugin.

Upon creating a new world i need to manually drag over a copy of the global configuration and put it in "Worldname"/Storage/SEWorldGenPlugin folder. Reason that i do that is whenever i create a new world it doesnt copy anything or re-use the global config but it just creates and uses default configuration. After ive done that it still doesnt reserve Moon defined planets only, they still get used as normal planets. Ive even tried to add the moons as blacklisted planets but that didnt do anything.

from seworldgenplugin.

So I know what the issue is. Sometimes, the plug-in may create a configuration file in the template folders for the world's, which is the used, because the plug-in thinks, the world already has a config file. You can look in the SE installation folder under Content and world's. There should be the templates and they should not have a storage folder inside. If they do, delete the config file for the plug-in inside of the templates storage folder. It's a bug that can't really be fixed and i don't know why it happens sometimes

from seworldgenplugin.

I did not know about that template folder, that might be why i need to re-add it after creating new worlds. I did re-use the same world name everytime i didnt get a good planet system. This however doesnt explain why moons still isnt excluded from being selected as planets though. I can send a copy of that XML file to you so you may take a look yourself at my set values as i did spend some time to get a decent system that i could play with in survival.

from seworldgenplugin.

If there is a config in the template folder for ex. empty world, every time you use the empty world template to create the world it gets used. If you overwrite the config file afterwards, the system is already generated and the planet and moon lists don't have an effect. They are only used, if the world does not have a system data file, which is at the creation of the world

from seworldgenplugin.

Upon world creation, ive seen the worldSettings.xml file being created and that file never gets the configuration from the original global configuration even if i select Use Global Config. SystemData.xml never gets generated on the first generation but after ive put my worldSettings.xml file in the config folder for that world and save-reload the world, it successfully generates the system and the file. GlobalGpsData does generate but does not get filled up with data about gps until the save and reload. AsteroidGeneratorData is the same case.
I did just check out the Content/CustomWorlds/Empty World/Storage folder and that folder has a SEWorldGenPlugin with the worldSettings.xml file with default configuration aswell as GlobalGpsData.xml and AsteroidGeneratorData.xml

from seworldgenplugin.

So that is exactly the issue I described. You have a config file in the template folder of the world. Those are I'm the Content folder of the SE installation.
System data only shows up when the map saves once. What does the config contain, that exists in the world folder after you create it? Not the global or your own comfig

from seworldgenplugin.

SystemData.xml does not show up even if i save right after creating a world, it will only show up after saving and reloading the same world after turning on the plugin for that world in Edit Settings. That might explain why i do not get planets immediately after generating the world. After deleting the Content/CustomWorlds/Empty World/Storage/SEWorldGenPlugin folder, it now properly takes a copy of global config but there is one exception; the top tag "Enabled" is set to false.

from seworldgenplugin.

Okay, so that might be a bug. Enabled should be set to the wether or not you enabled the plug-in on world creation. If you did not, then it is correct. If you did, then it is a bug that might need fixing

from seworldgenplugin.

It was selected to be enabled but it never generates planets and such on first world load. In fact none of the features that the plugin provides is generated on first world load. Only the second one will initiate and generate the planet system and belts and all.

from seworldgenplugin.

Do you always use the global config on load? This is the first time, such a problem exists.

from seworldgenplugin.

Not always, i did quickly test by enabling the plugin and generating the world without the Use Global Config checkmark and it started the world without anything generated. I generated a world with the Use Global Config checkmark on and everything generated according to that config. In other words it doesnt generate anything if Use Global Config isnt selected, it might be because the config it puts in the world before loading it doesnt have the Enabled set to true.

from seworldgenplugin.

Oh yeah, the config that is put inside the world that doesnt generate everything is identical to the global config, except for the Enabled tag which is set to false.

from seworldgenplugin.

That config should not event be put there. Can you change the values of the plug-in settings in-game before creating the world to see if they are used?

from seworldgenplugin.

I just tested and creating a world with the plugin settings set to something not standard but without Global Config set to true does reflect the same changed settings to the file in said world, but it still doesnt generate anything due to the config not being enabled.

from seworldgenplugin.

That doesn't make sense. Normally, when you press the checkbox to enable the plug-in for the world, it sets it to enabled in the config. Could you try setting the settings and then enable it after setting them but before creating the world? Could be, that the enabled value gets overwritten to the global config value, when closing the settings

from seworldgenplugin.

Doing the exact same thing you said did make it generate everything upon world creation. I set it to disabled, configured the settings and then enabled it again followed by creating the world and that did indeed create the planet system.
The global config does have it by default enabled as i did modify it myself to my desire when i got the plugin.

from seworldgenplugin.

Thank you. That should be a bug I did not know about which did appear due to some changes to config handling I did. I will fix it in the next couple days, when I find the time for it, but it should not be much work to do.

from seworldgenplugin.

Nice, i guess we got to the bottom of that problem. I guess in pursuit of finding out why the moons still spawned as planets brought us to that problem aswell.

from seworldgenplugin.

Yeah, I will fix it as soon as possible and hopefully it resolves the original issue

from seworldgenplugin.

Very nice. I may provide some testing if that is neccesary. If not then i will be waiting for the next update.

from seworldgenplugin.

Okay, i got on SE today, to verify the issue, with the config not being enabled. I could not verify it. UI checjked the code and the way i works, it should always be enabled, when you tick the box. If you check the box to enable the plugin, change some settings around and then go back, is the box still ticked?

from seworldgenplugin.

The checkbox is already ticked when i enter the world creation menu, and if i dont touch it and generate the world, it will not generate. That still happends even if i modify other settings. I did mention the fact that the global config was modified by me and that has enabled set to true.

from seworldgenplugin.

Okay, yeah, THATS the issue. Since your global config was enabled, the box is ticked right away, but i forgot to copy that value into the session config. I will fix it

from seworldgenplugin.