Conan package: build failure using c++17 (or later) with MSVC. about thorvg HOT 5 CLOSED

Thank you for raising the issue
Due to build errors caused by the definition overlap between std::byte introduced in C++17 and byte in windows.h, I will resolve this issue by adding the macro #define _HAS_STD_BYTE 0.

from thorvg.

just don't include all the headers from windows.h. Just before windows.h in tvgTtfLoader.cpp (and probably in all the source/header files which include windows.h), define WIN32_LEAN_AND_MEAN like that:

#ifndef WIN32_LEAN_AND_MEAN
#  define WIN32_LEAN_AND_MEAN
#endif
#include <windows.h>
#undef WIN32_LEAN_AND_MEAN

it works for me on mingw when using c++20.

from thorvg.

thank you for your suggestion. If it is possible to resolve this with the WIN32_LEAN_AND_MEAN macro , this solution seems preferable

thank you for your suggestion. If it is possible to resolve this with the WIN32_LEAN_AND_MEAN macro , this solution seems preferable

from thorvg.

@vsaulue Hello, the fix will be applied in v0.13.3. With the version, it will insert the addressed the definition - WIN32_LINEA_AND_MEAN in thorvg "config.h"

Please let us know if you have any trouble with the solution. Thanks.

from thorvg.

Hi @hermet,

I don't see a conanfile.py in the repo to test the Conan packaging, so I tested the build directly with git clone and meson instead. I was able to reproduce the errors on v0.13.2, and they are effectively gone on the main branch, so it looks good.

Thanks for the quick fix !

from thorvg.