tvg_set_frame fails on lastframe about thorvg HOT 3 CLOSED

@theashraf Hello, this is a good topic to discussion. Currently, tvg ignores the frame value if the difference is less than 0.001. How could people notice changes within 1ms? In most cases, in my opinion, updating the frames when the change is less than 1ms is just an unnecessary burden on the system.

In your case, the difference is approximately 0.00023, tvg returns the false to skip the frame update by user as it's intended to use like this:

if (animation->frame( new frame value) == success) {
   //Good to update the frame.
} else {
   //Not necessarily, skip the update.
}

Thus, I suggest a more practical test:

(total_frames - 1.0 - 0.001)

or

assert(animation->frame(new frame value) != Resut::NonSupport)

Please feel free to leave your opinion if you have different thought. Thanks.

from thorvg.

It looks like a floating-point precision problem.

from thorvg.

Thank you, @hermet. That makes sense

from thorvg.