Giter Club home page Giter Club logo

Comments (6)

capnm avatar capnm commented on June 13, 2024

Excerpt from current CI run https://github.com/capnm/godot4/actions/runs/6051776183/job/16426617328

WARNING: ThreadSanitizer: data race (pid=7060)
  Read of size 8 at 0x7b1000013b88 by thread T2:
    #0 std::vector<std::thread, std::allocator<std::thread> >::size() const /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/stl_vector.h:919:40 (godot.linuxbsd.editor.dev.x86_64.llvm.san+0x56b1969)
    #1 tvg::TaskSchedulerImpl::run(unsigned int) /home/runner/work/godot4/godot4/thirdparty/thorvg/src/renderer/tvgTaskScheduler.cpp:134:46 

https://github.com/thorvg/thorvg/blame/main/src/renderer/tvgTaskScheduler.cpp#L134


  Previous write of size 8 at 0x7b1000013b88 by main thread:
    #0 std::thread& std::vector<std::thread, std::allocator<std::thread> >::emplace_back<tvg::TaskSchedulerImpl::TaskSchedulerImpl(unsigned int)::'lambda'()>(tvg::TaskSchedulerImpl::TaskSchedulerImpl(unsigned int)::'lambda'()&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/vector.tcc:117:6 (godot.linuxbsd.editor.dev.x86_64.llvm.san+0x6f0b1d6)
    #1 tvg::TaskSchedulerImpl::TaskSchedulerImpl(unsigned int) /home/runner/work/godot4/godot4/thirdparty/thorvg/src/renderer/tvgTaskScheduler.cpp:117:21 
...
SUMMARY: ThreadSanitizer: data race lib/gcc/x86_64-linux-gnu/.../include/c++/10/bits/stl_vector.h:919:40
in std::vector<std::thread, std::allocator<std::thread> >::size() const

https://github.com/thorvg/thorvg/blob/main/src/renderer/tvgTaskScheduler.cpp#L117

from thorvg.

capnm avatar capnm commented on June 13, 2024

TODO:

Maybe also related to changes in Godot 4.2,
see Multi-threaded Scene Processing in Godot 4.1+

  • compare older releases

from thorvg.

hermet avatar hermet commented on June 13, 2024

Thanks for information.

I guess this patch could cause the problem.

77daecc764a0a8d59394fac7b3302b4ba53c80d4 (in v0.10.3)

    renderer task-scheduler: ++thread safety
    
    Currently, tasks are expected to be triggered from the main thread.
    This ensures preventing the popping of a thread from a worker thread.
    
    Previously, there was a potential deadlock problem...

Could you please revert only that patch?

from thorvg.

capnm avatar capnm commented on June 13, 2024

Could you please revert only that patch?

Branch with 77daecc was deleted?
image

from thorvg.

capnm avatar capnm commented on June 13, 2024

Oh ok. It is the same one I found with bisect as the first bad in main:

git revert 77de620
git revert 8f9bdeb

on curent ThorVG main b6e168b fixes the Error mentioned above and Godot renders all SVGs again :)

from thorvg.

hermet avatar hermet commented on June 13, 2024

77de620 obvisouly problem and i reverted. thanks!

from thorvg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.