Giter Club home page Giter Club logo

Comments (6)

thorsten avatar thorsten commented on June 16, 2024

I tested it on my local environment and it looks good, the URL looks like

https://localhost/news/4/de/no-news-are-good-news.html

The rewrite rule:

# * http://[...]/news/<ID>/<LANGUAGE CODE>/<HEADER>.html
RewriteRule news/([0-9]+)/([a-z\-]+)/(.+)\.htm(l?)$ index.php?action=news&newsid=$1&newslang=$2 [L,QSA]

from phpmyfaq.

tolew1 avatar tolew1 commented on June 16, 2024

Yes that is what I have but I get redirected to the 404 page. The odd thing is, the 404 page doesn't show the right template either. Because it shows things that I changed like showing the original phpmyfaq logo in the header.

I made a copy of the default theme and changed it to that theme in the admin. So not sure why it's reverting back to the default theme for the 404 page as well.

All the other seo faq links work. Just the news doesn't work with your exact rewrite rule. Does it matter my lang is en?

from phpmyfaq.

thorsten avatar thorsten commented on June 16, 2024

You have to change the 404 as well, it's not embedded in the index.html template file.

For the 404, it's really strange. Do you see an error in your apache log files?

from phpmyfaq.

tolew1 avatar tolew1 commented on June 16, 2024

I manage to fix the issue for me. It was Options +FollowSymLinks -MultiViews -Indexes Mine wasn't exactly as it is in your repo. It's weird how it only affected the news part.

For the 404 I don't know why it does that. And that is still an issue. Nothing in the apache logs.

from phpmyfaq.

tolew1 avatar tolew1 commented on June 16, 2024

You have to change the 404 as well, it's not embedded in the index.html template file.

I may have misunderstood your reply. The problem with the 404 page seems to be that it's not within the index.html file which is why the updates did not show as it did the rest of the site. So I think things are ok with this issue then.

from phpmyfaq.

thorsten avatar thorsten commented on June 16, 2024

Yes, the 404 page is not embedded in the "normal" index.html as the other templates. I think we should rename it to 404.page.html to make it more clear.

from phpmyfaq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.