hi apokalypz,

Could you try it now? I've fixed some issues with the html escaping on the settings page.

from redmine_ldap_sync.

I've just noticed that I'm using some prototype functions there. I'll have to replace those with jQuery.

from redmine_ldap_sync.

I've replaced the functions but I'm still having some trouble with the show/hide methods.
I'll review it later.

from redmine_ldap_sync.

I was having problems with my git repository.
I've fixed the show/hide methods and pushed everything to branch redmine-2.x.

from redmine_ldap_sync.

Hi,

I still have an error with the redmine-2.x branch :

Started GET "/settings/plugin/redmine_ldap_sync" for xxx.xxx.xxx.xxx at Fri Sep 14 08:12:24 +0200 2012
Processing by SettingsController#plugin as HTML
Parameters: {"id"=>"redmine_ldap_sync"}
Rendered plugins/redmine_ldap_sync/app/views/settings/_ldap_sync_settings.html.erb (2.6ms)
Rendered settings/plugin.html.erb within layouts/admin (3.8ms)
Completed 500 Internal Server Error in 9ms

ActionView::Template::Error (undefined method fetch' for "":String): 12: " 13: %> 14: <% AuthSourceLdap.all.each_with_index do |ldap, i| -%> 15: <fieldset class="collapsible <%= 'collapsed' unless ldap.ldapsync_active? %>"> 16: <legend onclick="toggleFieldset(this);"><%= ldap.name %></legend> 17: <div <%= 'style="display:none"' unless ldap.ldapsync_active? %>> 18: app/views/settings/plugin.html.erb:6:in_app_views_settings_plugin_html_erb__155630021__630437478'
app/views/settings/plugin.html.erb:4:in `_app_views_settings_plugin_html_erb__155630021__630437478'

Will try later to install a new redmine with only this plugin from scratch to see if I get the same error.

from redmine_ldap_sync.

It tried to install a new redmine instance from scratch (Centos 6/ using ruby 1.9.3 installed from sources and rails 3.2.6) and it seems to work fine.

from redmine_ldap_sync.

Tried with redmine 2.1, seems to work fine.

from redmine_ldap_sync.

I am excitedly waiting the compatibility with 2.1.2. :)

from redmine_ldap_sync.

atopcu, have you tried branch 2.x?

from redmine_ldap_sync.

Yes, I was tried it in 2.1.2

from redmine_ldap_sync.

And did work?
If not, can you send me the error you've gotten on the logs?

The redmine-2.x branch works ok on my redmine 2.1.2.
As so, any error you send me will be useful to fix it.

from redmine_ldap_sync.

Sorry, this is my mistake to select spesified branch. branch 2.x works very well.
Thank you so much thorin.

from redmine_ldap_sync.

My error

Completed 500 Internal Server Error in 5ms

ActionView::Template::Error (undefined method fetch' for "":String): 12: " 13: %> 14: <% AuthSourceLdap.all.each_with_index do |ldap, i| -%> 15: <fieldset class="collapsible <%= 'collapsed' unless ldap.ldapsync_active? %>"> 16: <legend onclick="toggleFieldset(this);"><%= ldap.name %></legend> 17: <div <%= 'style="display:none"' unless ldap.ldapsync_active? %>> 18: app/views/settings/plugin.html.erb:6:in_app_views_settings_plugin_html_erb___2044098256_70014593522360'
app/views/settings/plugin.html.erb:4:in `_app_views_settings_plugin_html_erb___2044098256_70014593522360

rails (3.2.8)
ruby (1.8.7)
redmine (2.1)

from redmine_ldap_sync.

Can you please provide the full stack trace?

from redmine_ldap_sync.

Since apokalypz managed to get it working on a instalation from scratch, it might be a problem with the migrations.

Did it stop working after you upgraded the plugin?

from redmine_ldap_sync.

its new instance

from redmine_ldap_sync.

git clone https://github.com/thorin/redmine_ldap_sync.git
Cloning into redmine_ldap_sync...
remote: Counting objects: 393, done.
remote: Compressing objects: 100% (213/213), done.
remote: Total 393 (delta 157), reused 343 (delta 108)
Receiving objects: 100% (393/393), 63.62 KiB, done.
Resolving deltas: 100% (157/157), done.
root@rack:/home/support/redmine-2.1/plugins# cd ./redmine_ldap_sync/
root@rack:/home/support/redmine-2.1/plugins/redmine_ldap_sync# ls -l
итого 68
drwxr-xr-x 3 root root 4096 Ноя 22 12:19 app
drwxr-xr-x 3 root root 4096 Ноя 22 12:19 assets
drwxr-xr-x 3 root root 4096 Ноя 22 12:19 config
drwxr-xr-x 3 root root 4096 Ноя 22 12:19 db
-rw-r--r-- 1 root root 1300 Ноя 22 12:19 init.rb
drwxr-xr-x 4 root root 4096 Ноя 22 12:19 lib
-rw-r--r-- 1 root root 35147 Ноя 22 12:19 LICENSE
-rwxr-xr-x 1 root root 7939 Ноя 22 12:19 README.md
root@rack:/home/support/redmine-2.1/plugins/redmine_ldap_sync# git remote -v
origin https://github.com/thorin/redmine_ldap_sync.git (fetch)
origin https://github.com/thorin/redmine_ldap_sync.git (push)
root@rack:/home/support/redmine-2.1/plugins/redmine_ldap_sync# git status

On branch master

nothing to commit (working directory clean)
root@rack:/home/support/redmine-2.1/plugins/redmine_ldap_sync# git branch -a

• master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
  remotes/origin/redmine-1.4.x
  root@rack:/home/support/redmine-2.1/plugins/redmine_ldap_sync# cd ..
  root@rack:/home/support/redmine-2.1/plugins# cd ..
  root@rack:/home/support/redmine-2.1# nano ./Gemfile
  root@rack:/home/support/redmine-2.1# /var/lib/gems/1.8/bin/bundle install --without development test postgresql sqlite rmagick
  Using rake (0.8.7)
  Using i18n (0.6.1)
  Using multi_json (1.3.7)
  Using activesupport (3.2.8)
  Using builder (3.0.0)
  Using activemodel (3.2.8)
  Using erubis (2.7.0)
  Using journey (1.0.4)
  Using rack (1.4.1)
  Using rack-cache (1.2)
  Using rack-test (0.6.2)
  Using hike (1.2.1)
  Using tilt (1.3.3)
  Using sprockets (2.1.3)
  Using actionpack (3.2.8)
  Using mime-types (1.19)
  Using polyglot (0.3.3)
  Using treetop (1.4.12)
  Using mail (2.4.4)
  Using actionmailer (3.2.8)
  Using arel (3.0.2)
  Using tzinfo (0.3.35)
  Using activerecord (3.2.8)
  Using activeresource (3.2.8)
  Using bundler (1.2.2)
  Using coderay (1.0.8)
  Using fastercsv (1.5.5)
  Using rack-ssl (1.3.2)
  Using json (1.7.5)
  Using rdoc (3.12)
  Using thor (0.16.0)
  Using railties (3.2.8)
  Using jquery-rails (2.0.3)
  Using mysql (2.8.1)
  Using net-ldap (0.3.1)
  Using ruby-openid (2.1.8)
  Using rack-openid (1.3.1)
  Using rails (3.2.8)
  Your bundle is complete! Use bundle show [gemname] to see where a bundled gem is installed.
  root@rack:/home/support/redmine-2.1# /var/lib/gems/1.8/bin/bundle update
  Fetching gem metadata from http://rubygems.org/.........
  Fetching gem metadata from http://rubygems.org/..
  Using rake (10.0.2)
  Using i18n (0.6.1)
  Using multi_json (1.3.7)
  Using activesupport (3.2.8)
  Using builder (3.0.0)
  Using activemodel (3.2.8)
  Using erubis (2.7.0)
  Using journey (1.0.4)
  Using rack (1.4.1)
  Using rack-cache (1.2)
  Using rack-test (0.6.2)
  Using hike (1.2.1)
  Using tilt (1.3.3)
  Using sprockets (2.1.3)
  Using actionpack (3.2.8)
  Using mime-types (1.19)
  Using polyglot (0.3.3)
  Using treetop (1.4.12)
  Using mail (2.4.4)
  Using actionmailer (3.2.8)
  Using arel (3.0.2)
  Using tzinfo (0.3.35)
  Using activerecord (3.2.8)
  Using activeresource (3.2.8)
  Using bundler (1.2.2)
  Using coderay (1.0.8)
  Using fastercsv (1.5.5)
  Using rack-ssl (1.3.2)
  Using json (1.7.5)
  Using rdoc (3.12)
  Using thor (0.16.0)
  Using railties (3.2.8)
  Using jquery-rails (2.0.3)
  Using mysql (2.8.1)
  Using net-ldap (0.3.1)
  Using ruby-openid (2.1.8)
  Using rack-openid (1.3.1)
  Using rails (3.2.8)
  Your bundle is updated! Use bundle show [gemname] to see where a bundled gem is installed.
  root@rack:/home/support/redmine-2.1# rake redmine:plugins:migrate RAILS_ENV=production --trace
  (in /home/support/redmine-2.1)
  rake aborted!
  uninitialized constant Rake::DSL
  /usr/lib/ruby/1.8/rake.rb:2503:in const_missing' /var/lib/gems/1.8/gems/rake-10.0.2/lib/rake/tasklib.rb:8 /var/lib/gems/1.8/gems/rake-10.0.2/lib/rake/testtask.rb:4:inrequire'
  /var/lib/gems/1.8/gems/rake-10.0.2/lib/rake/testtask.rb:4
  /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/test_unit/testing.rake:2:in require' /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/test_unit/testing.rake:2 /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/test_unit/railtie.rb:12:inload'
  /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/test_unit/railtie.rb:12
  /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/railtie.rb:184:in instance_exec' /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/railtie.rb:184:inload_tasks'
  /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/railtie.rb:184:in each' /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/railtie.rb:184:inload_tasks'
  /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/engine.rb:423:in load_tasks' /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/application/railties.rb:8:ineach'
  /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/application/railties.rb:8:in all' /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/engine.rb:423:inload_tasks'
  /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/application.rb:145:in load_tasks' /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/railtie/configurable.rb:30:insend'
  /var/lib/gems/1.8/gems/railties-3.2.8/lib/rails/railtie/configurable.rb:30:in method_missing' /home/support/redmine-2.1/Rakefile:7 /usr/lib/ruby/1.8/rake.rb:2383:inload'
  /usr/lib/ruby/1.8/rake.rb:2383:in raw_load_rakefile' /usr/lib/ruby/1.8/rake.rb:2017:inload_rakefile'
  /usr/lib/ruby/1.8/rake.rb:2068:in standard_exception_handling' /usr/lib/ruby/1.8/rake.rb:2016:inload_rakefile'
  /usr/lib/ruby/1.8/rake.rb:2000:in run' /usr/lib/ruby/1.8/rake.rb:2068:instandard_exception_handling'
  /usr/lib/ruby/1.8/rake.rb:1998:in `run'
  /usr/bin/rake:28
  root@rack:/home/support/redmine-2.1# nano ./Gemfile
  root@rack:/home/support/redmine-2.1# rake redmine:plugins:migrate RAILS_ENV=production --trace
  (in /home/support/redmine-2.1)
  You have requested:
  rake = 0.8.7

The bundle currently has rake locked at 10.0.2.
Try running bundle update rake
Run bundle install to install missing gems.
root@rack:/home/support/redmine-2.1# /var/lib/gems/1.8/bin/bundle update
Fetching gem metadata from http://rubygems.org/.........
Fetching gem metadata from http://rubygems.org/..
Using rake (0.8.7)
Using i18n (0.6.1)
Using multi_json (1.3.7)
Using activesupport (3.2.8)
Using builder (3.0.0)
Using activemodel (3.2.8)
Using erubis (2.7.0)
Using journey (1.0.4)
Using rack (1.4.1)
Using rack-cache (1.2)
Using rack-test (0.6.2)
Using hike (1.2.1)
Using tilt (1.3.3)
Using sprockets (2.1.3)
Using actionpack (3.2.8)
Using mime-types (1.19)
Using polyglot (0.3.3)
Using treetop (1.4.12)
Using mail (2.4.4)
Using actionmailer (3.2.8)
Using arel (3.0.2)
Using tzinfo (0.3.35)
Using activerecord (3.2.8)
Using activeresource (3.2.8)
Using bundler (1.2.2)
Using coderay (1.0.8)
Using fastercsv (1.5.5)
Using rack-ssl (1.3.2)
Using json (1.7.5)
Using rdoc (3.12)
Using thor (0.16.0)
Using railties (3.2.8)
Using jquery-rails (2.0.3)
Using mysql (2.8.1)
Using net-ldap (0.3.1)
Using ruby-openid (2.1.8)
Using rack-openid (1.3.1)
Using rails (3.2.8)
Your bundle is updated! Use bundle show [gemname] to see where a bundled gem is installed.
root@rack:/home/support/redmine-2.1# rake redmine:plugins:migrate RAILS_ENV=production --trace
(in /home/support/redmine-2.1)
** Invoke redmine:plugins:migrate (first_time)
** Invoke environment (first_time)
** Execute environment
** Execute redmine:plugins:migrate
Migrating redmine_ldap_sync (Redmine - Ldap Sync)...
** Invoke db:schema:dump (first_time)
** Invoke environment
** Invoke db:load_config (first_time)
** Execute db:load_config

** Execute db:schema:dump

Started GET "/settings/plugin/redmine_ldap_sync" for 192.168.1.56 at Thu Nov 22 12:22:52 +0400 2012
Processing by SettingsController#plugin as HTML
Parameters: {"id"=>"redmine_ldap_sync"}
(0.1ms) SELECT MAX(settings.updated_on) AS max_id FROM settings
User Load (0.1ms) SELECT users.* FROM users WHERE users.type IN ('User', 'AnonymousUser') AND users.id = ? AND (users.status = 1) LIMIT 1 [["id", 1]]
Current user: admin (id=1)
Setting Load (0.1ms) SELECT settings.* FROM settings WHERE settings.name = 'plugin_redmine_ldap_sync' LIMIT 1
AuthSourceLdap Load (0.1ms) SELECT auth_sources.* FROM auth_sources WHERE auth_sources.type IN ('AuthSourceLdap')
Rendered plugins/redmine_ldap_sync/app/views/settings/_ldap_sync_settings.html.erb (111.2ms)
Rendered settings/plugin.html.erb within layouts/admin (112.9ms)
Completed 500 Internal Server Error in 118ms

ActionView::Template::Error (undefined method fetch' for "":String): 12: " 13: %> 14: <% AuthSourceLdap.all.each_with_index do |ldap, i| -%> 15: <fieldset class="collapsible <%= 'collapsed' unless ldap.ldapsync_active? %>"> 16: <legend onclick="toggleFieldset(this);"><%= ldap.name %></legend> 17: <div <%= 'style="display:none"' unless ldap.ldapsync_active? %>> 18: app/views/settings/plugin.html.erb:6:in_app_views_settings_plugin_html_erb___2044098256_70014595054900'
app/views/settings/plugin.html.erb:4:in `_app_views_settings_plugin_html_erb___2044098256_70014595054900'

from redmine_ldap_sync.

Ok,

I though you had more lines after:

  app/views/settings/plugin.html.erb:4:in `_app_views_settings_plugin_html_erb___2044098256_70014595054900'

I'll have to try to reproduce it.

It's not clear on which line the error is originated. Maybe on the middle... line 15.

from redmine_ldap_sync.

app/views/settings/plugin.html.erb:4:in `_app_views_settings_plugin_html_erb___2044098256_70014595054900'
last message

from redmine_ldap_sync.

Closing since, the configuration page has changed on version 2.0.
Feel free to reopen the issue if you also have problems on this version.

from redmine_ldap_sync.