Hi, When I try to add multiple incoming/outgoing rules to distinct I

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

False positive errors when trying to add multiple rules about tcconfig HOT 2 CLOSED

thombashi commented on May 30, 2024

False positive errors when trying to add multiple rules

from tcconfig.

Comments (2)

thombashi commented on May 30, 2024

@dastergon
Thank you for your feedback.
I've fixed to suppress the message at tcconfig 0.14.0.
(the message also appears when I use --change)

+ tcset --direction outgoing --dst-network 192.168.122.205 --rate 500Mbps --device ens33 --overwrite
+ tcset --direction incoming --dst-network 192.168.122.205 --device ens33 --rate 500Mbps --add
+ tcshow -d ens33
{
    "ens33": {
        "outgoing": {
            "dst-network=192.168.122.205/32, protocol=ip": {
                "rate": "500M",
                "filter_id": "800::800"
            }
        },
        "incoming": {
            "dst-network=192.168.122.205/32, protocol=ip": {
                "rate": "500M",
                "filter_id": "800::800"
            }
        }
    }
}
+ tcset --direction outgoing --dst-network 192.168.122.201 --rate 500Mbps --device ens33 --add
+ tcset --direction incoming --dst-network 192.168.122.201 --device ens33 --rate 500Mbps --add
+ tcshow -d ens33
{
    "ens33": {
        "outgoing": {
            "dst-network=192.168.122.201/32, protocol=ip": {
                "rate": "500M",
                "filter_id": "800::801"
            },
            "dst-network=192.168.122.205/32, protocol=ip": {
                "rate": "500M",
                "filter_id": "800::800"
            }
        },
        "incoming": {
            "dst-network=192.168.122.201/32, protocol=ip": {
                "rate": "500M",
                "filter_id": "800::801"
            },
            "dst-network=192.168.122.205/32, protocol=ip": {
                "rate": "500M",
                "filter_id": "800::800"
            }
        }
    }
}
+ tcset --direction outgoing --dst-network 192.168.122.201 --rate 300Mbps --device ens33 --change
+ tcset --direction incoming --dst-network 192.168.122.201 --device ens33 --rate 300Mbps --change
+ tcshow -d ens33
{
    "ens33": {
        "outgoing": {
            "dst-network=192.168.122.201/32, protocol=ip": {
                "rate": "300M",
                "filter_id": "800::801"
            },
            "dst-network=192.168.122.205/32, protocol=ip": {
                "rate": "500M",
                "filter_id": "800::800"
            }
        },
        "incoming": {
            "dst-network=192.168.122.201/32, protocol=ip": {
                "rate": "300M",
                "filter_id": "800::801"
            },
            "dst-network=192.168.122.205/32, protocol=ip": {
                "rate": "500M",
                "filter_id": "800::800"
            }
        }
    }
}

Note: "filter_id" entry added to tcshow output to support #80.

from tcconfig.