url() not resolved correctly about wp-less HOT 8 CLOSED

I believe it has to do with the use of named back-references (https://github.com/oncletom/wp-less/search?q=%3FP%3C&ref=cmdform&type=Code) in preg_replace_callback, which is only supported in PHP 5.3 and above, from what I gather.

In PHP 5.2, those back-references fall through as numerically keyed arrays.

A temporary work-around for PHP 5.2 users is to change the array keys to their expected numerical index, as shown below from Plugin.class.php, around line 124.

    protected function _filterStylesheetUri($matches)
    {
        if (preg_match('#^(http|@|data:|/)#Ui', $matches[2])) {
            return $matches[0];
        }

        return sprintf('url(%s%s%1$s)',
            $matches[1],
            $this->_TmpBaseDir . '/' . $matches[2]
        );
    }

Long-term, the plugin author should cite PHP 5.3 as the minimum requirement, or simply remove the named back-reference dependencies.

A reasonable compromise, without sacrificing too much readability, is to pull the regex match into local variables via list:

    protected function _filterStylesheetUri($matches)
    {
        list($full, $quote, $url) = $matches;

        if (preg_match('#^(http|@|data:|/)#Ui', $url)) {
            return $full;
        }

        return sprintf('url(%s%s%1$s)',
            $quote,
            $this->_TmpBaseDir . '/' . $url
        );
    }

from wp-less.

hmm, I would like to see that plugin having no greater requirements than wordpress, which has php 5.2 afair.
this would only lead to lots of negative reviews, since hosters don't always have the latest and greatest...

from wp-less.

Back-reference are available in PHP 5.2 — http://www.php.net/manual/en/regexp.reference.back-references.php

from wp-less.

@oncletom Yes, but it seems that named back-references were not allowed to propagate outside of the pattern until PHP 5.3.

from wp-less.

I've found a Stack Overflow answer that seems to reinforce the above assertion: http://stackoverflow.com/a/5255199

from wp-less.

OK well, if it's the only blocking problem for PHP 5.2, I invite you to open a pull request with this change.
Thanks for coining the problem :-)

from wp-less.

pull request here: #39

from wp-less.

I close the issue thanks to #39 and ship that in a new release (because I forgot to do it 2 months ago).

from wp-less.