Better UI integration with FlightRadar24 in addition to FlightAware about docker-fr24feed-piaware-dump1090 HOT 9 CLOSED

Great ! You can do a PR and we will create a new docker tag to test if it's OK.

from docker-fr24feed-piaware-dump1090.

It could be a good idea ! I don't really have time to do that but I would be happy to accept PR for it (and review them).

I'm not a front end expert, but I could help on the Docker part. 👍

from docker-fr24feed-piaware-dump1090.

Yes, time is an issue ;) I'm putting this on my todo list.

from docker-fr24feed-piaware-dump1090.

Thank you !

from docker-fr24feed-piaware-dump1090.

Hi @Thom-x , I've set up an initial patching setup that adds the FR24 logo and uses a neutral page name. This is how it looks like until now:

Before I go too far down that road, could you give it a try and tell me if that is in line with what you'd expect?

I've added a bit of explanation on how to run the original script that creates the patch file, not sure if it helps.
Basically I created a .patch file that modifies 4 files from the upstream release, and that file gets plugged into the Dockerfile.

Note: The patch works fine for v3.8.1 (the current target of "latest"), but fails on v4.0 because upstream added extra whitespace in the public_html/script.js file, in the updatePiAwareOrFlightFeeder() function that gets patched. Simple to update when v4.0 (or likely 4.1) is ready for usage.

from docker-fr24feed-piaware-dump1090.

Just to add a bit more context:

• The "real" work happens here in the Dockerfile, in which:
  • The FR24 logo gets copied
  • The patch/flightradar24.patch file gets applied that modifies the index page to add the logo and the js files for a neutral page name

from docker-fr24feed-piaware-dump1090.

PR created with the code until now. I'm running a Raspi 1B, when creating/publishing the new Docker tag can you make sure to upload also the arm version? Thanks.

from docker-fr24feed-piaware-dump1090.

Thanks for merging #45. Since there are more changes coming up in #49, @Thom-x can you reopen this issue and link the new PR to this issue too?

from docker-fr24feed-piaware-dump1090.

Great, thanks for merging both PRs!

from docker-fr24feed-piaware-dump1090.