Giter Club home page Giter Club logo

Comments (10)

thlorenz avatar thlorenz commented on July 17, 2024

Have a go at it and provide a PR. As long as it doesn't break current functionality (mainly working with browserify), I'm ok to merge it.

from brace.

genbit avatar genbit commented on July 17, 2024

Another solution is to use noParse webpack configuration:

noParse: [
"/brace/"
],

from brace.

thlorenz avatar thlorenz commented on July 17, 2024

Closing, but still open to a PR that adds this.

from brace.

JamesHenry avatar JamesHenry commented on July 17, 2024

Hey @joelgriffith, just FYI a fix was committed to webpack parser today for this: webpack/webpack@27b23c0

from brace.

thlorenz avatar thlorenz commented on July 17, 2024

Ah, nice so this works with webpack now as well as with browserify?

from brace.

JamesHenry avatar JamesHenry commented on July 17, 2024

Seems to so far :) Apologies that it is a bit off topic for this thread, but do you have any documentation for creating/using custom ACE modes with Brace? Many thanks!

from brace.

thlorenz avatar thlorenz commented on July 17, 2024

Not entirely sure, but there was a similar issue which had a solution: #14

from brace.

joelgriffith avatar joelgriffith commented on July 17, 2024

Awesome! I'll have to give it a spin sometime later.

from brace.

JamesHenry avatar JamesHenry commented on July 17, 2024

To be honest, now that the webpack parser bug has been fixed, webpack seems to be working fine with ACE itself (using src-noconflict)... Maybe Brace will be Browserify-only after all :D

from brace.

thlorenz avatar thlorenz commented on July 17, 2024

Well that's fine, I bet it doesn't inline workers though, so you'd still have to serve those.
Being able to browserify was just one reason I implemented brace, see

from brace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.